lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 20 May 2022 17:35:01 +0800 From: Miles Chen <miles.chen@...iatek.com> To: <yassine.oudjana@...il.com> CC: <angelogioacchino.delregno@...labora.com>, <bgolaszewski@...libre.com>, <chun-jie.chen@...iatek.com>, <devicetree@...r.kernel.org>, <ikjn@...omium.org>, <krzysztof.kozlowski+dt@...aro.org>, <linux-arm-kernel@...ts.infradead.org>, <linux-clk@...r.kernel.org>, <linux-kernel@...r.kernel.org>, <linux-mediatek@...ts.infradead.org>, <matthias.bgg@...il.com>, <miles.chen@...iatek.com>, <mturquette@...libre.com>, <p.zabel@...gutronix.de>, <robh+dt@...nel.org>, <sam.shih@...iatek.com>, <sboyd@...nel.org>, <tinghan.shen@...iatek.com>, <weiyi.lu@...iatek.com>, <wenst@...omium.org>, <y.oudjana@...tonmail.com>, <~postmarketos/upstreaming@...ts.sr.ht> Subject: Re: [PATCH v2 4/4] clk: mediatek: Add drivers for MediaTek MT6735 main clock drivers >> >> Thanks for submitting this patch. >> >> I compare this with drivers/clk/mediatek/clk-mt7986-apmixed.c, >> and other clk files are using macros to make the mtk_pll_data array >> more readable. > >I'd actually argue that macros make it less readable. While reading >other drivers I had a lot of trouble figuring out which argument >is which field of the struct, and had to constantly go back to the >macro definitions and count arguments to find it. Having it this >way, each value is labeled clearly with the field it's in. I think >the tradeoff between line count and readability here is worth it. It is easier for multiple developers to work together if we have a common style. How do you think? Thanks, Miles > >> >> Would you mind following the same style for all c files, please? >> >> e.g., >> static const struct mtk_pll_data plls[] = { >> PLL(CLK_APMIXED_ARMPLL, "armpll", 0x0200, 0x020C, 0x00000001, 0, 32, >> 0x0200, 4, 0, 0x0204, 0), >> PLL(CLK_APMIXED_NET2PLL, "net2pll", 0x0210, 0x021C, 0x00000001, 0, >> 32, >> 0x0210, 4, 0, 0x0214, 0), >> ... >> }; >> >>> + }, >>> + .reg = APLL1_CON0, >>> + .pwr_reg = APLL1_PWR_CON0, >>> +module_platform_driver(clk_mt6735_apmixedsys); >>> + >>> +MODULE_AUTHOR("Yassine Oudjana <y.oudjana@...tonmail.com>"); >>> +MODULE_DESCRIPTION("Mediatek MT6735 apmixedsys clock driver"); >> >> Would you mind changing all Mediatek to MediaTek? >> i.e., >> >> s/Mediatek/MediaTek/ >> > >Sure. Will fix it. thanks > >> >> thanks, >> Miles >> +MODULE_LICENSE("GPL"); >> > >Thanks, >Yassine > > > >
Powered by blists - more mailing lists