| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <7b451dfb-8353-4a4e-1834-a01feaa267d2@linaro.org>
Date: Fri, 20 May 2022 12:31:58 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Luca Weiss <luca.weiss@...rphone.com>,
linux-arm-msm@...r.kernel.org
Cc: ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
Andy Gross <agross@...nel.org>,
Bjorn Andersson <bjorn.andersson@...aro.org>,
Georgi Djakov <djakov@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Odelu Kukatla <okukatla@...eaurora.org>,
linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/5] dt-bindings: interconnect: Add Qualcomm SM6350 NoC
support
On 20/05/2022 09:03, Luca Weiss wrote:
> Add bindings for Qualcomm SM6350 Network-On-Chip interconnect devices.
>
> As SM6350 has two pairs of NoCs sharing the same reg, allow this in the
> binding documentation, as was done for qcm2290.
>
> Because the main qcom,rpmh.yaml file is getting too complicated for our
> use cases, create a new qcom,rpmh-common.yaml and a separate
> qcom,sm6350-rpmh.yaml that defines our new bindings.
>
> Signed-off-by: Luca Weiss <luca.weiss@...rphone.com>
> ---
> Changes since v1:
> * Split sm6350 into separate yaml with new rpmh-common.yaml
>
> .../interconnect/qcom,rpmh-common.yaml | 41 +++++
> .../interconnect/qcom,sm6350-rpmh.yaml | 82 ++++++++++
> .../dt-bindings/interconnect/qcom,sm6350.h | 148 ++++++++++++++++++
> 3 files changed, 271 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,rpmh-common.yaml
> create mode 100644 Documentation/devicetree/bindings/interconnect/qcom,sm6350-rpmh.yaml
> create mode 100644 include/dt-bindings/interconnect/qcom,sm6350.h
>
> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,rpmh-common.yaml b/Documentation/devicetree/bindings/interconnect/qcom,rpmh-common.yaml
> new file mode 100644
> index 000000000000..6121eea3e87d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,rpmh-common.yaml
> @@ -0,0 +1,41 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interconnect/qcom,rpmh-common.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm RPMh Network-On-Chip Interconnect
> +
> +maintainers:
> + - Georgi Djakov <georgi.djakov@...aro.org>
> + - Odelu Kukatla <okukatla@...eaurora.org>
Is this valid email address?
> +
> +description: |
> + RPMh interconnect providers support system bandwidth requirements through
> + RPMh hardware accelerators known as Bus Clock Manager (BCM). The provider is
> + able to communicate with the BCM through the Resource State Coordinator (RSC)
> + associated with each execution environment. Provider nodes must point to at
> + least one RPMh device child node pertaining to their RSC and each provider
> + can map to multiple RPMh resources.
> +
> +properties:
> + '#interconnect-cells':
> + enum: [ 1, 2 ]
Why this is an enum?
> +
> + qcom,bcm-voters:
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + items:
Please implement my previous comments.
> + maxItems: 1
> + description: |
No need for |
> + List of phandles to qcom,bcm-voter nodes that are required by
> + this interconnect to send RPMh commands.
> +
> + qcom,bcm-voter-names:
What names do you expect here?
> + description: |
Ditto.
> + Names for each of the qcom,bcm-voters specified.
> +
> +required:
> + - '#interconnect-cells'
> + - qcom,bcm-voters
> +
> +additionalProperties: true
> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,sm6350-rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,sm6350-rpmh.yaml
> new file mode 100644
> index 000000000000..89fe17c31b8f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,sm6350-rpmh.yaml
> @@ -0,0 +1,82 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interconnect/qcom,sm6350-rpmh.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm SM6350 RPMh Network-On-Chip Interconnect
> +
> +maintainers:
> + - Luca Weiss <luca.weiss@...rphone.com>
> +
> +description: |
> + Qualcomm RPMh-based interconnect provider on SM6350.
> +
> +allOf:
> + - $ref: qcom,rpmh-common.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + - qcom,sm6350-aggre1-noc
> + - qcom,sm6350-aggre2-noc
> + - qcom,sm6350-config-noc
> + - qcom,sm6350-dc-noc
> + - qcom,sm6350-gem-noc
> + - qcom,sm6350-mmss-noc
> + - qcom,sm6350-npu-noc
> + - qcom,sm6350-system-noc
> +
> + reg:
> + maxItems: 1
> +
> + '#interconnect-cells': true
Since you defined it as enum in rpmh-common, you really expect here
different values?
> +
> +required:
> + - compatible
> + - reg
> +
> +unevaluatedProperties: false
> +
> +patternProperties:
This goes after "properties".
> + '^interconnect-[a-z0-9\-]+$':
> + type: object
> + description:
> + The interconnect providers do not have a separate QoS register space,
> + but share parent's space.
> + $ref: qcom,rpmh-common.yaml#
> +
> + properties:
> + compatible:
> + enum:
> + - qcom,sm6350-clk-virt
> + - qcom,sm6350-compute-noc
> +
> + '#interconnect-cells': true
Same problem.
> +
> + required:
> + - compatible
> +
> + unevaluatedProperties: false
> +
Best regards,
Krzysztof
Powered by blists - more mailing lists