linux-kernel - Re: [PATCH] [v2] media/platform-wide: platform: Add moli to the match table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <67deb2d6-cb04-ddb3-6c24-14d8ecb31ed9@xs4all.nl>
Date:   Fri, 20 May 2022 12:48:26 +0200
From:   Hans Verkuil <hverkuil-cisco@...all.nl>
To:     Scott Chao <scott_chao@...tron.corp-partner.google.com>
Cc:     mchehab@...nel.org, bleung@...omium.org, groeck@...omium.org,
        zhuohao@...omium.org, linux-media@...r.kernel.org,
        chrome-platform@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [v2] media/platform-wide: platform: Add moli to the match
 table

Huh? The Subject is now *really* bad. I think you misunderstood my comment
on the original patch.

"[PATCH] media: platform: foo" suggests a patch touching on many drivers in
drivers/media/platform. But this patch only touches on a single driver, so:

"[PATCH] media: platform: cros-ec: foo"

That way the maintainer of that driver will see the name of the driver in the
subject as well, and might comment upon it.

Regards,

	Hans

On 5/20/22 12:42, Scott Chao wrote:
> The Google Moli device uses the same approach as the Google Brask
> which enables the HDMI CEC via the cros-ec-cec driver.
> 
> Signed-off-by: Scott Chao <scott_chao@...tron.corp-partner.google.com>
> ---
>  drivers/media/cec/platform/cros-ec/cros-ec-cec.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
> index 8c8d8fc5e63e..25dc7309beab 100644
> --- a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
> +++ b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
> @@ -217,6 +217,8 @@ static const struct cec_dmi_match cec_dmi_match_table[] = {
>  	{ "Google", "Fizz", "0000:00:02.0", "Port B" },
>  	/* Google Brask */
>  	{ "Google", "Brask", "0000:00:02.0", "Port B" },
> +	/* Google Moli */
> +	{ "Google", "Moli", "0000:00:02.0", "Port B" },
>  };
>  
>  static struct device *cros_ec_cec_find_hdmi_dev(struct device *dev,