linux-kernel - Re: [PATCH v2 0/1] s390: Add attestation query information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yod3Uiu2hRc9vas7@osiris>
Date:   Fri, 20 May 2022 13:11:14 +0200
From:   Heiko Carstens <hca@...ux.ibm.com>
To:     Steffen Eiden <seiden@...ux.ibm.com>
Cc:     Christian Borntraeger <borntraeger@...ux.ibm.com>,
        Janosch Frank <frankja@...ux.ibm.com>,
        Claudio Imbrenda <imbrenda@...ux.ibm.com>,
        Nico Boehr <nrb@...ux.ibm.com>, linux-s390@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/1] s390: Add attestation query information

On Wed, May 18, 2022 at 01:59:07PM +0000, Steffen Eiden wrote:
> By design the uv-device does not check whether an incoming attestation
> measurement request only specifies valid plaintext flags or has the
> right request version, as these values are verified by the Ultravisor
> anyway. However, the userspace program that generates these requests
> might want to know which flags/versions are supported in order to
> create requests without trial and error. Therefore, we must expose the
> supported plaintext flags and versions to userspace.
> 
> since v1:
> 	* rebased on Janosch's "kvm: s390: Add PV dump support" series
> 	* added rationale as this cover letter

Thanks for adding the cover letter! However what I really meant (and
failed to write) is that the rationale should be part of the patch
description. Anyway; whoever picks this patch will hopefully integrate
your cover letter description into the commit.