linux-kernel - Re: [PATCH] scsi: hisi_sas: Fix memory ordering in hisi_sas_task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <165300891232.11465.16554701363800250632.b4-ty@oracle.com>
Date:   Thu, 19 May 2022 21:09:11 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     John Garry <john.garry@...wei.com>, jejb@...ux.ibm.com
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-scsi@...r.kernel.org, linuxarm@...wei.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: hisi_sas: Fix memory ordering in hisi_sas_task_deliver()

On Tue, 17 May 2022 16:04:21 +0800, John Garry wrote:

> The memories for the slot should be observed to be written prior to
> observing the slot as ready.
> 
> Prior to commit 26fc0ea74fcb ("scsi: libsas: Drop SAS_TASK_AT_INITIATOR"),
> we had a spin_lock() + spin_unlock() immediately before marking the slot
> as ready. The spin_unlock() - with release semantics - caused the slot
> memory to be observed to be written.
> 
> [...]

Applied to 5.19/scsi-queue, thanks!

[1/1] scsi: hisi_sas: Fix memory ordering in hisi_sas_task_deliver()
      https://git.kernel.org/mkp/scsi/c/6c6ac8b7773f

-- 
Martin K. Petersen	Oracle Linux Engineering