linux-kernel - Re: [PATCH] drm/msm/adreno: Do not propagate void return values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 20 May 2022 06:14:09 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Rob Clark <robdclark@...il.com>, Sean Paul <sean@...rly.run>,
        Abhinav Kumar <quic_abhinavk@...cinc.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>
Cc:     linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        freedreno@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/msm/adreno: Do not propagate void return values

On 5/20/22 05:53, Geert Uytterhoeven wrote:
> With sparse ("make C=2"), lots of
> 
>    error: return expression in void function
> 
> messages are seen.
> 
> Fix this by removing the return statements to propagate void return
> values.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 2 +-
>   drivers/gpu/drm/msm/adreno/a6xx_gmu.h | 4 ++--
>   drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 2 +-
>   3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> index 3e325e2a2b1b68eb..d137136d93f3b4ca 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
> @@ -504,7 +504,7 @@ static void a6xx_rpmh_stop(struct a6xx_gmu *gmu)
>   
>   static inline void pdc_write(void __iomem *ptr, u32 offset, u32 value)
>   {
> -	return msm_writel(value, ptr + (offset << 2));
> +	msm_writel(value, ptr + (offset << 2));
>   }
>   
>   static void __iomem *a6xx_gmu_get_mmio(struct platform_device *pdev,
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.h b/drivers/gpu/drm/msm/adreno/a6xx_gmu.h
> index 84bd516f01e895b2..e034935b3986f9f2 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.h
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.h
> @@ -98,7 +98,7 @@ static inline u32 gmu_read(struct a6xx_gmu *gmu, u32 offset)
>   
>   static inline void gmu_write(struct a6xx_gmu *gmu, u32 offset, u32 value)
>   {
> -	return msm_writel(value, gmu->mmio + (offset << 2));
> +	msm_writel(value, gmu->mmio + (offset << 2));
>   }
>   
>   static inline void
> @@ -138,7 +138,7 @@ static inline u32 gmu_read_rscc(struct a6xx_gmu *gmu, u32 offset)
>   
>   static inline void gmu_write_rscc(struct a6xx_gmu *gmu, u32 offset, u32 value)
>   {
> -	return msm_writel(value, gmu->rscc + (offset << 2));
> +	msm_writel(value, gmu->rscc + (offset << 2));
>   }
>   
>   #define gmu_poll_timeout_rscc(gmu, addr, val, cond, interval, timeout) \
> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> index ccc4fcf7a630f49a..d671b75f3289fdff 100644
> --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu.c
> @@ -1446,7 +1446,7 @@ static void a6xx_llc_rmw(struct a6xx_gpu *a6xx_gpu, u32 reg, u32 mask, u32 or)
>   
>   static void a6xx_llc_write(struct a6xx_gpu *a6xx_gpu, u32 reg, u32 value)
>   {
> -	return msm_writel(value, a6xx_gpu->llc_mmio + (reg << 2));
> +	msm_writel(value, a6xx_gpu->llc_mmio + (reg << 2));
>   }
>   
>   static void a6xx_llc_deactivate(struct a6xx_gpu *a6xx_gpu)