linux-kernel - Re: [RFC PATCH v3 1/6] [PATCH 1/6] mm: refactor of vma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220520132800.hijytnlyjqeesjfj@box.shutemov.name>
Date:   Fri, 20 May 2022 16:28:00 +0300
From:   "Kirill A. Shutemov" <kirill@...temov.name>
To:     Jakub Matěna <matenajakub@...il.com>
Cc:     linux-mm@...ck.org, patches@...ts.linux.dev,
        linux-kernel@...r.kernel.org, vbabka@...e.cz, mhocko@...nel.org,
        mgorman@...hsingularity.net, willy@...radead.org,
        liam.howlett@...cle.com, hughd@...gle.com, riel@...riel.com,
        rostedt@...dmis.org, peterz@...radead.org, david@...hat.com
Subject: Re: [RFC PATCH v3 1/6] [PATCH 1/6] mm: refactor of vma_merge()

On Mon, May 16, 2022 at 02:54:00PM +0200, Jakub Matěna wrote:
> Refactor vma_merge() to make it shorter, more understandable and
> suitable for tracing of successful merges that are made possible by
> following patches in the series. Main change is the elimination of code
> duplicity in the case of merge next check. This is done by first doing
> checks and caching the results before executing the merge itself. Exit
> paths are also unified.
> 
> Signed-off-by: Jakub Matěna <matenajakub@...il.com>

Okay, this looks good:

Acked-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>

I would also consider renaming 'area' to 'vma'. 'area' feels wrong to me,
but maybe it is only me.

-- 
 Kirill A. Shutemov