linux-kernel - Re: [PATCH] KVM: x86: Inhibit APICv/AVIC when changing apic id/base from the defaults

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YoezHLoQ3J2mjv1n@google.com>
Date:   Fri, 20 May 2022 15:26:20 +0000
From:   Sean Christopherson <seanjc@...gle.com>
To:     Zeng Guang <guang.zeng@...el.com>
Cc:     Paolo Bonzini <pbonzini@...hat.com>,
        Maxim Levitsky <mlevitsk@...hat.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "H . Peter Anvin" <hpa@...or.com>, kvm@...r.kernel.org,
        x86@...nel.org, linux-kernel@...r.kernel.org,
        Gao Chao <chao.gao@...el.com>
Subject: Re: [PATCH] KVM: x86: Inhibit APICv/AVIC when changing apic id/base
 from the defaults

On Fri, May 20, 2022, Zeng Guang wrote:
> From: Maxim Levitsky <mlevitsk@...hat.com>
> 
> Neither of these settings should be changed by the guest and it is a burden
> to support it in the acceleration code, so just inhibit APICv/AVIC in case
> such rare cases happen.
> 
> Signed-off-by: Maxim Levitsky <mlevitsk@...hat.com>
> Signed-off-by: Zeng Guang <guang.zeng@...el.com>
> ---

All of my comments on Maxim's posting still apply[*].  At this point, unless Paolo
wants wield his hammer of authority and do a bunch of fixup, the fastest way forward
will be to wait for Maxim to respond and post patches 1-3 of that series separately.

[*] https://lore.kernel.org/all/YoZrG3n5fgMp4LQl@google.com