linux-kernel - Re: [PATCH] char/mem: only use {read,write}_iter, not the old {read,write} functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yoe3ROmrA8sNe3Cb@zeniv-ca.linux.org.uk>
Date:   Fri, 20 May 2022 15:44:04 +0000
From:   Al Viro <viro@...iv.linux.org.uk>
To:     Jens Axboe <axboe@...nel.dk>
Cc:     "Jason A. Donenfeld" <Jason@...c4.com>, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] char/mem: only use {read,write}_iter, not the old
 {read,write} functions

On Fri, May 20, 2022 at 09:32:34AM -0600, Jens Axboe wrote:

> Didn't look closer, but I'm assuming this is _mostly_ tied to needing to
> init 48 bytes of kiocb for each one. There might be ways to embed a
> sync_kiocb inside the kiocb for the bits we need there, at least that
> could get us down to 32 bytes.

My bet would be on iocb_flags() (and kiocb_set_rw_flags()) tests and
pointer-chasing, actually.  I'd been sick on and off since early November,
trying to dig myself from under the piles right now.  Christoph's
patches in that area are somewhere in the pile ;-/