linux-kernel - Re: arch/mips/include/asm/checksum.h:195:9: error: unsupported inline asm: input with type 'unsigned long' matching output with type '_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yoe5TafDskZ9JDSW@dev-arch.thelio-3990X>
Date:   Fri, 20 May 2022 08:52:45 -0700
From:   Nathan Chancellor <nathan@...nel.org>
To:     "Maciej W. Rozycki" <macro@...am.me.uk>
Cc:     Paul Cercueil <paul@...pouillou.net>,
        kernel test robot <lkp@...el.com>, llvm@...ts.linux.dev,
        kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        linux-mips <linux-mips@...r.kernel.org>
Subject: Re: arch/mips/include/asm/checksum.h:195:9: error: unsupported
 inline asm: input with type 'unsigned long' matching output with type
 '__wsum' (aka 'unsigned int')

On Fri, May 20, 2022 at 12:08:02PM +0100, Maciej W. Rozycki wrote:
> On Thu, 19 May 2022, Paul Cercueil wrote:
> 
> > About the real issue: Maybe the last "addu" in csum_tcpudp_nofold() should be
> > a "daddu"?
> 
>  It doesn't matter whether there is ADDU or DADDU anymore, given that 
> commit 198688edbf77 ("MIPS: Fix inline asm input/output type mismatch in 
> checksum.h used with Clang") has added a redundant 32-bit sign-extension 
> operation right afterwards, regressing size/performance by an extra 
> instruction in this performance-critical code as a workaround for a stupid 
> compiler.

Shouldn't this concern have been addressed by Tiezhu's follow up?

https://lore.kernel.org/1617359240-16609-1-git-send-email-yangtiezhu@loongson.cn/

I guess it never got picked up?

Cheers,
Nathan