linux-kernel - Re: [PATCH] KVM: arm64: cancel the return value check of kvm_arm_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 21 May 2022 13:31:10 +0800
From:   kernel test robot <lkp@...el.com>
To:     Peng Wu <wupeng58@...wei.com>, maz@...nel.org, james.morse@....com,
        alexandru.elisei@....com, catalin.marinas@....com, will@...nel.org
Cc:     kbuild-all@...ts.01.org, linux-arm-kernel@...ts.infradead.org,
        kvmarm@...ts.cs.columbia.edu, linux-kernel@...r.kernel.org,
        liwei391@...wei.com, yuehaibing@...wei.com, wupeng58@...wei.com
Subject: Re: [PATCH] KVM: arm64: cancel the return value check of
 kvm_arm_init_sve()

Hi Peng,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on kvmarm/next]
[also build test ERROR on v5.18-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Peng-Wu/KVM-arm64-cancel-the-return-value-check-of-kvm_arm_init_sve/20220520-165501
base:   https://git.kernel.org/pub/scm/linux/kernel/git/kvmarm/kvmarm.git next
config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20220521/202205211307.MWDiBNQS-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/4f7983bee8e912289335be279fb1f0a0abd6b31b
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Peng-Wu/KVM-arm64-cancel-the-return-value-check-of-kvm_arm_init_sve/20220520-165501
        git checkout 4f7983bee8e912289335be279fb1f0a0abd6b31b
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> arch/arm64/kvm/reset.c:46:6: error: conflicting types for 'kvm_arm_init_sve'; have 'void(void)'
      46 | void kvm_arm_init_sve(void)
         |      ^~~~~~~~~~~~~~~~
   In file included from include/linux/kvm_host.h:45,
                    from arch/arm64/kvm/reset.c:13:
   arch/arm64/include/asm/kvm_host.h:70:5: note: previous declaration of 'kvm_arm_init_sve' with type 'int(void)'
      70 | int kvm_arm_init_sve(void);
         |     ^~~~~~~~~~~~~~~~


vim +46 arch/arm64/kvm/reset.c

    45	
  > 46	void kvm_arm_init_sve(void)
    47	{
    48		if (system_supports_sve()) {
    49			kvm_sve_max_vl = sve_max_virtualisable_vl();
    50	
    51			/*
    52			 * The get_sve_reg()/set_sve_reg() ioctl interface will need
    53			 * to be extended with multiple register slice support in
    54			 * order to support vector lengths greater than
    55			 * VL_ARCH_MAX:
    56			 */
    57			if (WARN_ON(kvm_sve_max_vl > VL_ARCH_MAX))
    58				kvm_sve_max_vl = VL_ARCH_MAX;
    59	
    60			/*
    61			 * Don't even try to make use of vector lengths that
    62			 * aren't available on all CPUs, for now:
    63			 */
    64			if (kvm_sve_max_vl < sve_max_vl())
    65				pr_warn("KVM: SVE vector length for guests limited to %u bytes\n",
    66					kvm_sve_max_vl);
    67		}
    68	}
    69	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp