linux-kernel - Re: [PATCH V11 09/22] LoongArch: Add boot and setup routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7caec251-20e7-4a8c-93ee-b28558ec580f@redhat.com>
Date:   Sat, 21 May 2022 11:06:21 +0200
From:   Javier Martinez Canillas <javierm@...hat.com>
To:     Huacai Chen <chenhuacai@...il.com>
Cc:     Ard Biesheuvel <ardb@...nel.org>,
        Huacai Chen <chenhuacai@...ngson.cn>,
        Arnd Bergmann <arnd@...db.de>,
        Andy Lutomirski <luto@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        David Airlie <airlied@...ux.ie>,
        Jonathan Corbet <corbet@....net>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-arch <linux-arch@...r.kernel.org>,
        Linux Doc Mailing List <linux-doc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Xuefeng Li <lixuefeng@...ngson.cn>,
        Yanteng Si <siyanteng@...ngson.cn>,
        Guo Ren <guoren@...nel.org>, Xuerui Wang <kernel@...0n.name>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        linux-efi <linux-efi@...r.kernel.org>
Subject: Re: [PATCH V11 09/22] LoongArch: Add boot and setup routines

Hello Huacai,

On 5/21/22 09:37, Huacai Chen wrote:

[snip]

>>
>> A problem with moving to subsys_initcall_sync() is that this will delay
>> more when a display is available in the system, and just to cope up with
>> a corner case (as mentioned the common case is native drivers as module).
> OK, your method seems better, but I think moving to
> subsys_initcall_sync() can make the screen display as early as
> possible.
>

But it doesn't cover all cases. For example, you will get the same error
if for example your native driver is built-in and efifb built as module.
 
So my opinion is that instead of playing with the init call levels, is
just better for you to build your native driver as a module instead of
making it built-in.

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat