linux-kernel - Re: [PATCH 1/2] s390: Kconfig: Fix indentation and add comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 21 May 2022 12:35:03 +0200
From:   Juerg Haefliger <juerg.haefliger@...onical.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Juerg Haefliger <juerg.haefliger@...onical.com>, hca@...ux.ibm.com,
        gor@...ux.ibm.com, agordeev@...ux.ibm.com,
        borntraeger@...ux.ibm.com, svens@...ux.ibm.com,
        linux-s390@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] s390: Kconfig: Fix indentation and add comments

On Fri, 20 May 2022 10:15:38 -0700
Joe Perches <joe@...ches.com> wrote:

> On Fri, 2022-05-20 at 13:57 +0200, Juerg Haefliger wrote:
> > The convention for indentation seems to be a single tab. Help text is
> > further indented by an additional two whitespaces. Fix the lines that
> > violate these rules.
> > 
> > While add it, add trailing comments to endmenu statements for better
> > readability.  
> []
> > diff --git a/arch/s390/Kconfig b/arch/s390/Kconfig  
> []
> > @@ -607,7 +607,7 @@ config RANDOMIZE_BASE
> >  	  as a security feature that deters exploit attempts relying on
> >  	  knowledge of the location of kernel internals.
> >  
> > -endmenu
> > +endmenu # "Processor type and features"  
> 
> An endmenu comment is relatively unusual.
> 
> $ git grep '^endmenu' -- '*/Kconfig*' | wc -l
> 394
> $ git grep '^endmenu.*#' -- '*/Kconfig*' | wc -l
> 20
> 
> I believe it doesn't really help readability.

Thanks for the review. Will send a v2 without that.

...Juerg

> 


Content of type "application/pgp-signature" skipped