linux-kernel - Re: [PATCH v3] i2c: add support for microchip fpga i2c controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YojM8KiGJneGh16D@shikoro>
Date:   Sat, 21 May 2022 13:28:48 +0200
From:   Wolfram Sang <wsa@...nel.org>
To:     Conor.Dooley@...rochip.com
Cc:     linux-i2c@...r.kernel.org, ben.dooks@...ethink.co.uk,
        Daire.McNamara@...rochip.com, linux-kernel@...r.kernel.org,
        linux-riscv@...ts.infradead.org
Subject: Re: [PATCH v3] i2c: add support for microchip fpga i2c controllers


> > > +	ret = devm_request_irq(&pdev->dev, irq, mchp_corei2c_isr, IRQF_SHARED,
> > > +			       pdev->name, idev);
> > 
> > Really SHARED?
> 
> Yeah, this driver supports both the hard peripherals & soft FPGA cores.
> The hard peripherals do not have shared IRQs, but we don't really have
> any control over what way the interrupts are wired for the soft cores.
> Worth adding a comment to explain the reason for it being shared?

Yes. Such information never hurst, I'd say.

Thanks, have a nice weekend,

   Wolfram


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)