linux-kernel - Re: [PATCH v2 2/2] dt-bindings: arm: mtk-clocks: Set #clock-cells as required property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <288690ac-b23b-92f8-64b4-d994f249f21c@linaro.org>
Date:   Sat, 21 May 2022 16:05:01 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Rob Herring <robh@...nel.org>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
Cc:     krzysztof.kozlowski+dt@...aro.org, matthias.bgg@...il.com,
        sboyd@...nel.org, chun-jie.chen@...iatek.com,
        rex-bc.chen@...iatek.com, wenst@...omium.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] dt-bindings: arm: mtk-clocks: Set #clock-cells as
 required property

On 21/05/2022 00:19, Rob Herring wrote:
> On Wed, May 18, 2022 at 11:36:31AM +0200, AngeloGioacchino Del Regno wrote:
>> This is a clock-controller binding, so it needs #clock-cells, or
>> it would be of no use: add that to the list of required properties.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
>> Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> ---
>>  .../devicetree/bindings/arm/mediatek/mediatek,mt8186-clock.yaml  | 1 +
>>  .../bindings/arm/mediatek/mediatek,mt8186-sys-clock.yaml         | 1 +
>>  .../devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml  | 1 +
>>  .../bindings/arm/mediatek/mediatek,mt8192-sys-clock.yaml         | 1 +
>>  .../devicetree/bindings/arm/mediatek/mediatek,mt8195-clock.yaml  | 1 +
>>  .../bindings/arm/mediatek/mediatek,mt8195-sys-clock.yaml         | 1 +
>>  6 files changed, 6 insertions(+)
> 
> Acked-by: Rob Herring <robh@...nel.org>
> 
> Wasn't there some discussion about moving these to bindings/clocks/? 
> Maybe that was another one, it's all a blur...

Yes, there was such idea although I am not sure if this is worth by
itself - messes up with the git history.


Best regards,
Krzysztof