linux-kernel - [PATCH 3/4] pinctrl: bcm: Use regmap_field_{set/clear}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <180e7052574.1144f2ff745882.256639936280011408@zohomail.com>
Date:   Sat, 21 May 2022 07:28:35 -0700
From:   Li Chen <lchen.firstlove@...omail.com>
To:     "Mark Brown" <broonie@...nel.org>,
        "linux-kernel" <linux-kernel@...r.kernel.org>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        "linux-gpio" <linux-gpio@...r.kernel.org>,
        "Linus Walleij" <linus.walleij@...aro.org>,
        "linux-arm-kernel" <linux-arm-kernel@...ts.infradead.org>,
        "Patrice Chotard" <patrice.chotard@...s.st.com>,
        "linux-sunxi" <linux-sunxi@...ts.linux.dev>,
        "Liam Girdwood" <lgirdwood@...il.com>,
        "Jaroslav Kysela" <perex@...ex.cz>,
        "Takashi Iwai" <tiwai@...e.com>, "Chen-Yu Tsai" <wens@...e.org>,
        "Jernej Skrabec" <jernej.skrabec@...il.com>,
        "Samuel Holland" <samuel@...lland.org>,
        "Philipp Zabel" <p.zabel@...gutronix.de>
Subject: [PATCH 3/4] pinctrl: bcm: Use regmap_field_{set/clear}_bits helpers

From: Li Chen <lchen@...arella.com>

Appropriately change calls to regmap_field_update_bits()
with regmap_field_clear_bits() for improved readability.

Signed-off-by: Li Chen <lchen@...arella.com>
---
 drivers/pinctrl/bcm/pinctrl-bcm6358.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pinctrl/bcm/pinctrl-bcm6358.c b/drivers/pinctrl/bcm/pinctrl-bcm6358.c
index 9f6cd7447887..b03dfcb171d1 100644
--- a/drivers/pinctrl/bcm/pinctrl-bcm6358.c
+++ b/drivers/pinctrl/bcm/pinctrl-bcm6358.c
@@ -300,7 +300,7 @@ static int bcm6358_gpio_request_enable(struct pinctrl_dev *pctldev,
 		return 0;
 
 	/* disable all functions using this pin */
-	return regmap_field_update_bits(priv->overlays, mask, 0);
+	return regmap_field_clear_bits(priv->overlays, mask);
 }
 
 static const struct pinctrl_ops bcm6358_pctl_ops = {
-- 
2.36.1