linux-kernel - Re: [PATCH v3] staging: r8188eu: add check for kzalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 22 May 2022 00:05:34 +0300
From:   Pavel Skripkin <paskripkin@...il.com>
To:     Phillip Potter <phil@...lpotter.co.uk>
Cc:     Martin Kaiser <lists@...ser.cx>,
        Jiasheng Jiang <jiasheng@...as.ac.cn>,
        dan.carpenter@...cle.com, Larry.Finger@...inger.net,
        gregkh@...uxfoundation.org, straube.linux@...il.com,
        fmdefrancesco@...il.com, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] staging: r8188eu: add check for kzalloc

Hi Phillip,

On 5/21/22 23:56, Phillip Potter wrote:
> Hi Pavel,
> 
> I agree with you totally - we should change these semantics to reflect
> how the rest of the kernel generally does things. That said, that is a
> bigger patch set and I noticed the driver was broken before I read this
> thread, so I've submitted a patch already just to fix the breakage for
> now.
> 
> Changing these semantics is a bigger patch/patchset and I wanted to get
> this out in the meantime - if you are looking at doing this conversion I
> will by all means leave that alone as no desire to tread on anyones
> toes :-)
> 

I think, redoing more then 500 place will take quite a long time, but 
driver should be fixed ASAP.

So let's apply your patch and then someone (maybe me) will cook a patch.




With regards,
Pavel Skripkin