linux-kernel - Re: [PATCH] hv_netvsc: Fix potential dereference of NULL pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <254e80a1.30e69.180e4ae082b.Coremail.lyz_cs@pku.edu.cn>
Date:   Sat, 21 May 2022 11:34:12 +0800 (GMT+08:00)
From:   刘永志 <lyz_cs@....edu.cn>
To:     agross@...nel.org, bjorn.andersson@...aro.org, jic23@...nel.org,
        lars@...afoo.de, svarbanov@...sol.com, iivanov@...sol.com,
        jonathan.cameron@...wei.com
Cc:     linux-arm-msm@...r.kernel.org, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hv_netvsc: Fix potential dereference of NULL pointer



I'm sorry to send this to linux-iio by mistake. I will cautiously submit patches later.

> -----Original Messages-----
> From: "Yongzhi Liu" <lyz_cs@....edu.cn>
> Sent Time: 2022-05-21 11:31:02 (Saturday)
> To: agross@...nel.org, bjorn.andersson@...aro.org, jic23@...nel.org, lars@...afoo.de, svarbanov@...sol.com, iivanov@...sol.com, jonathan.cameron@...wei.com
> Cc: linux-arm-msm@...r.kernel.org, linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org, fuyq@....pku.edu.cn, "Yongzhi Liu" <lyz_cs@....edu.cn>
> Subject: [PATCH] hv_netvsc: Fix potential dereference of NULL pointer
> 
> The return value of netvsc_devinfo_get()
> needs to be checked to avoid use of NULL
> pointer in case of an allocation failure.
> 
> Fixes: 0efeea5fb ("hv_netvsc: Add the support of hibernation")
> 
> Signed-off-by: Yongzhi Liu <lyz_cs@....edu.cn>
> ---
>  drivers/net/hyperv/netvsc_drv.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
> index fde1c49..b1dece6 100644
> --- a/drivers/net/hyperv/netvsc_drv.c
> +++ b/drivers/net/hyperv/netvsc_drv.c
> @@ -2671,7 +2671,10 @@ static int netvsc_suspend(struct hv_device *dev)
>  
>  	/* Save the current config info */
>  	ndev_ctx->saved_netvsc_dev_info = netvsc_devinfo_get(nvdev);
> -
> +	if (!ndev_ctx->saved_netvsc_dev_info) {
> +		ret = -ENOMEM;
> +		goto out;
> +	}
>  	ret = netvsc_detach(net, nvdev);
>  out:
>  	rtnl_unlock();
> -- 
> 2.7.4