linux-kernel - Re: [PATCH V3 0/6] iio: accel: bmi088: support BMI085 BMI090L

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220522123719.3e34bb6e@jic23-huawei>
Date:   Sun, 22 May 2022 12:37:19 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     LI Qingwu <Qing-wu.Li@...ca-geosystems.com.cn>
Cc:     lars@...afoo.de, mchehab+huawei@...nel.org, ardeleanalex@...il.com,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        robh+dt@...nel.org, mike.looijmans@...ic.nl,
        devicetree@...r.kernel.org, thomas.haemmerle@...ca-geosystems.com
Subject: Re: [PATCH V3 0/6] iio: accel: bmi088: support BMI085 BMI090L

On Wed, 18 May 2022 15:04:19 +0000
LI Qingwu <Qing-wu.Li@...ca-geosystems.com.cn> wrote:

> Modified the units after application of scale from 100*m/s^2 to m/s^2,
> since the units in the ABI documents are m/s^2.
> Add supports for the BMI085 accelerometer.
> Add supports for the BMI090L accelerometer.
> Make it possible to config scales.
> 
> Change in V3: 
> 
> Use FIELD_GET for checking register range. Reorder the chip info and 
> dt-bindings alphabetical. Add of_id_table. Modify the logic of loading
> sensor chip info. If the device was found in the table but the device 
> tree binding is different, the driver will carry on with the detected
> chip with a warning. If no matching device was found, the driver load
> the binding chip.

All looks good to me. Unfortunately we've missed the 5.19 merge window
now as it will probably open shortly.  As such we have lots of time so
I'll leave this on list for a little longer for others to take a look at.
Thanks,

Jonathan

> 
> 
> LI Qingwu (6):
>   iio: accel: bmi088: Modified the scale calculate
>   iio: accel: bmi088: Make it possible to config scales
>   iio: accel: bmi088: modified the device name
>   iio: accel: bmi088: Add support for bmi085 accel
>   iio: accel: bmi088: Add support for bmi090l accel
>   dt-bindings: iio: accel: Add bmi085 and bmi090l bindings
> 
>  .../bindings/iio/accel/bosch,bmi088.yaml      |  2 +
>  drivers/iio/accel/bmi088-accel-core.c         | 96 +++++++++++++++----
>  drivers/iio/accel/bmi088-accel-spi.c          | 17 +++-
>  drivers/iio/accel/bmi088-accel.h              |  9 +-
>  4 files changed, 100 insertions(+), 24 deletions(-)
>