linux-kernel - Re: [PATCH] scripts: kconfig: nconf: make nconfig accept jk keybindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNATfGqzikgDLvK2tTK91ynDsS59G7K7OZobyd+=MOqF_4A@mail.gmail.com>
Date:   Tue, 24 May 2022 02:14:27 +0900
From:   Masahiro Yamada <masahiroy@...nel.org>
To:     Isak Ellmer <isak01@...il.com>
Cc:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] scripts: kconfig: nconf: make nconfig accept jk keybindings

On Mon, May 16, 2022 at 6:24 PM Isak Ellmer <isak01@...il.com> wrote:
>
> Make nconfig accept jk keybindings for movement in addition to arrow keys.
>
> Signed-off-by: Isak Ellmer <isak01@...il.com>
> ---


I am fine with this.


Can you update the help message?


Around line 55:

"Linewise up                 <Up>\n"
"Linewise down               <Down>\n"










>  scripts/kconfig/nconf.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/scripts/kconfig/nconf.c b/scripts/kconfig/nconf.c
> index 7b371bd7fb36..ded40e5aabf8 100644
> --- a/scripts/kconfig/nconf.c
> +++ b/scripts/kconfig/nconf.c
> @@ -1105,9 +1105,11 @@ static void conf(struct menu *menu)
>                                 break;
>                         switch (res) {
>                         case KEY_DOWN:
> +                       case 'j':
>                                 menu_driver(curses_menu, REQ_DOWN_ITEM);
>                                 break;
>                         case KEY_UP:
> +                       case 'k':
>                                 menu_driver(curses_menu, REQ_UP_ITEM);
>                                 break;
>                         case KEY_NPAGE:
> @@ -1287,9 +1289,11 @@ static void conf_choice(struct menu *menu)
>                                 break;
>                         switch (res) {
>                         case KEY_DOWN:
> +                       case 'j':
>                                 menu_driver(curses_menu, REQ_DOWN_ITEM);
>                                 break;
>                         case KEY_UP:
> +                       case 'k':
>                                 menu_driver(curses_menu, REQ_UP_ITEM);
>                                 break;
>                         case KEY_NPAGE:
> --
> 2.35.1
>


-- 
Best Regards
Masahiro Yamada