linux-kernel - Re: [PATCH v1 0/5] iio: treewide: rearrange iio trig get/register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VeuAxMWknoG28v8k-gKCpUQFJbwpq+pTaTVPeY45vQo2w@mail.gmail.com>
Date:   Mon, 23 May 2022 19:40:27 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Dmitry Rokosov <DDRokosov@...rdevices.ru>
Cc:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "jic23@...nel.org" <jic23@...nel.org>,
        "lars@...afoo.de" <lars@...afoo.de>,
        "lorenzo.bianconi83@...il.com" <lorenzo.bianconi83@...il.com>,
        "linus.walleij@...aro.org" <linus.walleij@...aro.org>,
        "stephan@...hold.net" <stephan@...hold.net>,
        "hdegoede@...hat.com" <hdegoede@...hat.com>,
        "antoniu.miclaus@...log.com" <antoniu.miclaus@...log.com>,
        "sean@...nix.com" <sean@...nix.com>,
        "linmq006@...il.com" <linmq006@...il.com>,
        "gwendal@...omium.org" <gwendal@...omium.org>,
        "yangyingliang@...wei.com" <yangyingliang@...wei.com>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
        kernel <kernel@...rdevices.ru>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 0/5] iio: treewide: rearrange iio trig get/register

On Mon, May 23, 2022 at 6:42 PM Dmitry Rokosov <DDRokosov@...rdevices.ru> wrote:
>
> The following patchset resolves problems with iio_trigger_get() and
> iio_trigger_register() call order in the different IIO drivers.
>
> IIO trigger interface function iio_trigger_get() should be called after
> iio_trigger_register() (or its devm analogue) strictly, because of
> iio_trigger_get() acquires module refcnt based on the trigger->owner
> pointer, which is initialized inside iio_trigger_register() to
> THIS_MODULE.
> If this call order is wrong, the next iio_trigger_put() (from sysfs
> callbacks or rmmod) will derefence "default" module refcnt, which is

dereference

> completely incorrect.

Cool set! But it sounds like a set of fixes, can you add a Fixes tag
to each of the patches?

-- 
With Best Regards,
Andy Shevchenko