linux-kernel - Re: [PATCH next] m68k: virt: Switch to new sys-off handler API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d51916d6-5be3-4bdb-ffba-39ad3ae2d5e4@collabora.com>
Date:   Mon, 23 May 2022 21:01:35 +0300
From:   Dmitry Osipenko <dmitry.osipenko@...labora.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>
Cc:     Laurent Vivier <laurent@...ier.eu>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org,
        noreply@...erman.id.au
Subject: Re: [PATCH next] m68k: virt: Switch to new sys-off handler API

On 5/23/22 20:55, Geert Uytterhoeven wrote:
> On m68k with CONFIG_VIRT=y (e.g. virt_defconfig or allmodconfig):
> 
>     arch/m68k/virt/config.c: In function ‘config_virt’:
>     arch/m68k/virt/config.c:129:2: error: ‘mach_power_off’ undeclared (first use in this function); did you mean ‘pm_power_off’?
>       129 |  mach_power_off = virt_halt;
> 	  |  ^~~~~~~~~~~~~~
> 	  |  pm_power_off
> 
> Commit 05d51e42df06f021 ("m68k: Introduce a virtual m68k machine")
> introduced a new user of mach_power_off.
> Convert it to the new sys-off handler API, too.
> 
> Reported-by: noreply@...erman.id.au
> Fixes: f0f7e5265b3b37b0 ("m68k: Switch to new sys-off handler API")
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---
>  arch/m68k/virt/config.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/m68k/virt/config.c b/arch/m68k/virt/config.c
> index 68d29c8b87e18840..632ba200ad425245 100644
> --- a/arch/m68k/virt/config.c
> +++ b/arch/m68k/virt/config.c
> @@ -1,5 +1,6 @@
>  // SPDX-License-Identifier: GPL-2.0
>  
> +#include <linux/reboot.h>
>  #include <linux/serial_core.h>
>  #include <clocksource/timer-goldfish.h>
>  
> @@ -126,5 +127,6 @@ void __init config_virt(void)
>  	mach_get_model = virt_get_model;
>  	mach_reset = virt_reset;
>  	mach_halt = virt_halt;
> -	mach_power_off = virt_halt;
> +
> +	register_platform_power_off(virt_halt);
>  }

Thanks, Geert! Indeed, I only compile-tested files that were directly
affected by the core changes and haven't checked the whole m68k build,
that was my oversight.

Reviewed-by: Dmitry Osipenko <dmitry.osipenko@...labora.com>

-- 
Best regards,
Dmitry