linux-kernel - Re: [PATCH] ASoC: stm32: sai: Use of_device_get_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YovZAf4S0XphBsco@sirena.org.uk>
Date:   Mon, 23 May 2022 19:57:05 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Olivier MOYSAN <olivier.moysan@...s.st.com>
Cc:     Tang Bin <tangbin@...s.chinamobile.com>,
        arnaud.pouliquen@...s.st.com, lgirdwood@...il.com, perex@...ex.cz,
        tiwai@...e.com, mcoquelin.stm32@...il.com,
        alexandre.torgue@...s.st.com, alsa-devel@...a-project.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: stm32: sai: Use of_device_get_match_data() to
 simplify code

On Mon, May 23, 2022 at 03:28:48PM +0200, Olivier MOYSAN wrote:

> The current patch requires a change in the driver.
> Either changing STM_SAI_x_ID enums, or replacing data by a struct.
> For instance:
> struct stm32_sai_comp_data {
> 	unsigned int id;
> }
> struct stm32_sai_comp_data stm32_sai_comp_data_a = {
> 	.id = STM_SAI_A_ID;
> }
> struct of_device_id stm32_sai_sub_ids[] = {
> 	.data = &stm32_sai_comp_data_a},
> }

Either approach works for me (or a revert for that matter).

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)