linux-kernel - Re: [PATCH 2/2] ARM: dts: imx: Add devicetree for Kobo Aura 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220523210542.0735dd5f@aktux>
Date:   Mon, 23 May 2022 21:05:42 +0200
From:   Andreas Kemnade <andreas@...nade.info>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
        arnd@...db.de, olof@...om.net, soc@...nel.org, shawnguo@...nel.org,
        s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com,
        linux-imx@....com, l.stach@...gutronix.de,
        alexander.stein@...tq-group.com, marcel.ziswiler@...adex.com,
        linux@...pel-privat.de, matthias.schiffer@...tq-group.com,
        cniedermaier@...electronics.com, sebastian.reichel@...labora.com,
        leoyang.li@....com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        nicolecrivain@...il.com
Subject: Re: [PATCH 2/2] ARM: dts: imx: Add devicetree for Kobo Aura 2

On Mon, 23 May 2022 12:03:09 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:

[...]
> > +
> > +	gpio_keys: gpio-keys {
> > +		compatible = "gpio-keys";
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&pinctrl_gpio_keys>;
> > +
> > +		cover {  
> 
> Generic node names. You could add suffix if needed, so either key or
> key-cover.
> 
hmm, the example in
Documentation/devicetree/bindings/input/gpio-keys.yaml

shows names like I did. I usually expect to trust binding documentation
to have something acceptable.

> > +			label = "Cover";
> > +			gpios = <&gpio5 12 GPIO_ACTIVE_LOW>;
> > +			linux,code = <SW_LID>;
> > +			linux,input-type = <EV_SW>;
> > +			wakeup-source;
> > +		};
> > +
> > +		power {
> > +			label = "Power";
> > +			gpios = <&gpio5 8 GPIO_ACTIVE_LOW>;
> > +			linux,code = <KEY_POWER>;
> > +			wakeup-source;
> > +		};
> > +	};
> > +
> > +	leds: leds {
> > +		compatible = "gpio-leds";
> > +		pinctrl-names = "default";
> > +		pinctrl-0 = <&pinctrl_led>;
> > +
> > +		on {  
> 
> The same. You also need property for color.
> 
here the documentation clearly indicates led-.*|led

Regards,
Andreas