linux-kernel - Re: [linux-next:master 12308/12886] arch/x86/kvm/hyperv.c:1983:22: warning: shift count >= width of type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <CA+G9fYtaz2MO_-yxwtqQx+Gxm460mr2S++fFCYAqObacEL1X-Q@mail.gmail.com>
Date:   Mon, 23 May 2022 11:19:42 +0530
From:   Naresh Kamboju <naresh.kamboju@...aro.org>
To:     Nathan Chancellor <nathan@...nel.org>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Yury Norov <yury.norov@...il.com>
Cc:     kernel test robot <lkp@...el.com>, llvm@...ts.linux.dev,
        kbuild-all@...ts.01.org,
        Linux Memory Management List <linux-mm@...ck.org>,
        Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Sean Christopherson <seanjc@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Wanpeng Li <wanpengli@...cent.com>,
        kvm list <kvm@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        X86 ML <x86@...nel.org>, lkft-triage@...ts.linaro.org
Subject: Re: [linux-next:master 12308/12886] arch/x86/kvm/hyperv.c:1983:22:
 warning: shift count >= width of type

On Fri, 20 May 2022 at 21:18, Nathan Chancellor <nathan@...nel.org> wrote:
>
> Hi Yury,
>
> On Fri, May 20, 2022 at 04:24:32PM +0800, kernel test robot wrote:
> > tree:   https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
> > head:   21498d01d045c5b95b93e0a0625ae965b4330ebe
> > commit: 81db71a60292e9a40ae8f6ef137b17f2aaa15a52 [12308/12886] KVM: x86: hyper-v: replace bitmap_weight() with hweight64()
> > config: i386-randconfig-a011 (https://download.01.org/0day-ci/archive/20220520/202205201624.A4IhDdYX-lkp@intel.com/config)
> > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project e00cbbec06c08dc616a0d52a20f678b8fbd4e304)
> > reproduce (this is a W=1 build):
> >         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> >         chmod +x ~/bin/make.cross
> >         # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=81db71a60292e9a40ae8f6ef137b17f2aaa15a52
> >         git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git
> >         git fetch --no-tags linux-next master
> >         git checkout 81db71a60292e9a40ae8f6ef137b17f2aaa15a52
> >         # save the config file
> >         mkdir build_dir && cp config build_dir/.config
> >         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@...el.com>
> >
> > All warnings (new ones prefixed by >>):
> >
> > >> arch/x86/kvm/hyperv.c:1983:22: warning: shift count >= width of type [-Wshift-count-overflow]
> >                    if (hc->var_cnt != hweight64(valid_bank_mask))
> >                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~
> >    include/asm-generic/bitops/const_hweight.h:29:49: note: expanded from macro 'hweight64'
> >    #define hweight64(w) (__builtin_constant_p(w) ? __const_hweight64(w) : __arch_hweight64(w))
> >                                                    ^~~~~~~~~~~~~~~~~~~~
> >    include/asm-generic/bitops/const_hweight.h:21:76: note: expanded from macro '__const_hweight64'
> >    #define __const_hweight64(w) (__const_hweight32(w) + __const_hweight32((w) >> 32))
> >                                                                               ^  ~~
> >    include/asm-generic/bitops/const_hweight.h:20:49: note: expanded from macro '__const_hweight32'
> >    #define __const_hweight32(w) (__const_hweight16(w) + __const_hweight16((w) >> 16))
> >                                                    ^
> >    note: (skipping 1 expansions in backtrace; use -fmacro-backtrace-limit=0 to see all)
> >    include/asm-generic/bitops/const_hweight.h:10:9: note: expanded from macro '__const_hweight8'
> >             ((!!((w) & (1ULL << 0))) +     \
> >                   ^
> >    include/linux/compiler.h:56:47: note: expanded from macro 'if'
> >    #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) )
> >                                                  ^~~~
> >    include/linux/compiler.h:58:52: note: expanded from macro '__trace_if_var'
> >    #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond))
> >                                                       ^~~~

LKFT build system found these build warnings / errors on Linux next-20220520.

> I think this is the proper fix, as valid_bank_mask is only assigned u64
> values. Could you fold it into that patch to clear this warning up?

The proposed patch below was tested and it fixed the reported problem on 32-bit

> Cheers,
> Nathan
>
> diff --git a/arch/x86/kvm/hyperv.c b/arch/x86/kvm/hyperv.c
> index b652b856df2b..e2e95a6fccfd 100644
> --- a/arch/x86/kvm/hyperv.c
> +++ b/arch/x86/kvm/hyperv.c
> @@ -1914,7 +1914,7 @@ static u64 kvm_hv_send_ipi(struct kvm_vcpu *vcpu, struct kvm_hv_hcall *hc)
>         struct hv_send_ipi_ex send_ipi_ex;
>         struct hv_send_ipi send_ipi;
>         DECLARE_BITMAP(vcpu_mask, KVM_MAX_VCPUS);
> -       unsigned long valid_bank_mask;
> +       u64 valid_bank_mask;
>         u64 sparse_banks[KVM_HV_MAX_SPARSE_VCPU_SET_BITS];
>         u32 vector;
>         bool all_cpus;

Reported-by: Linux Kernel Functional Testing <lkft@...aro.org>
Tested-by: Linux Kernel Functional Testing <lkft@...aro.org>

--
Linaro LKFT
https://lkft.linaro.org