linux-kernel - Re: [Intel-wired-lan] [PATCH] drivers/net/ethernet/intel: fix typos in comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 23 May 2022 08:01:00 +0200
From:   Paul Menzel <pmenzel@...gen.mpg.de>
To:     Julia Lawall <julia.lawall@...ia.fr>
Cc:     Jesse Brandeburg <jesse.brandeburg@...el.com>,
        Tony Nguyen <anthony.l.nguyen@...el.com>,
        intel-wired-lan@...ts.osuosl.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org, Eric Dumazet <edumazet@...gle.com>,
        netdev@...r.kernel.org, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [Intel-wired-lan] [PATCH] drivers/net/ethernet/intel: fix typos
 in comments

Dear Julia,


Am 23.05.22 um 07:40 schrieb Julia Lawall:

> On Mon, 23 May 2022, Paul Menzel wrote:

>> Thank you for your patch.
>>
>> I noticed, that the maintainer Tony wasn’t in the Cc: list.
> 
> get_maintainer reports him as a "supporter", and I think that my script
> only takes people listed as "maintainer".

     INTEL ETHERNET DRIVERS
     M:      Jesse Brandeburg <jesse.brandeburg@...el.com>
     M:      Tony Nguyen <anthony.l.nguyen@...el.com>

For the changed files, both are listed as supporter by 
`get_maintainer.pl`, but only Jesse was taken. Not important, just 
wanted to mention it.

> 
>> Am 21.05.22 um 13:11 schrieb Julia Lawall:
>>> Spelling mistakes (triple letters) in comments.
>>> Detected with the help of Coccinelle.
>>
>> I’d be interested in the script you used.
> 
> Attached.  It should have a pretty low rate of false positives.  Mostly
> things like Eeew and Wheee.

Thank you.


Kind regards,

Paul


>>> Signed-off-by: Julia Lawall <Julia.Lawall@...ia.fr>
>>>
>>
>> Nit: One unneeded blank line.
> 
> OK, thanks.
> 
> julia
> 
>>> ---
>>>    drivers/net/ethernet/intel/fm10k/fm10k_mbx.c   |    2 +-
>>>    drivers/net/ethernet/intel/ice/ice_lib.c       |    2 +-
>>>    drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c |    2 +-
>>>    3 files changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_mbx.c
>>> b/drivers/net/ethernet/intel/fm10k/fm10k_mbx.c
>>> index 30ca9ee1900b..f2fba6e1d0f7 100644
>>> --- a/drivers/net/ethernet/intel/fm10k/fm10k_mbx.c
>>> +++ b/drivers/net/ethernet/intel/fm10k/fm10k_mbx.c
>>> @@ -1825,7 +1825,7 @@ static void fm10k_sm_mbx_process_error(struct
>>> fm10k_mbx_info *mbx)
>>>    		fm10k_sm_mbx_connect_reset(mbx);
>>>    		break;
>>>    	case FM10K_STATE_CONNECT:
>>> -		/* try connnecting at lower version */
>>> +		/* try connecting at lower version */
>>>    		if (mbx->remote) {
>>>    			while (mbx->local > 1)
>>>    				mbx->local--;
>>> diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c
>>> b/drivers/net/ethernet/intel/ice/ice_lib.c
>>> index 454e01ae09b9..70961c0343e7 100644
>>> --- a/drivers/net/ethernet/intel/ice/ice_lib.c
>>> +++ b/drivers/net/ethernet/intel/ice/ice_lib.c
>>> @@ -2403,7 +2403,7 @@ static void ice_set_agg_vsi(struct ice_vsi *vsi)
>>>    				agg_id);
>>>    			return;
>>>    		}
>>> -		/* aggregator node is created, store the neeeded info */
>>> +		/* aggregator node is created, store the needed info */
>>>    		agg_node->valid = true;
>>>    		agg_node->agg_id = agg_id;
>>>    	}
>>> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
>>> b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
>>> index 3e74ab82868b..3f5ef5269bb2 100644
>>> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
>>> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
>>> @@ -77,7 +77,7 @@ static int __ixgbe_enable_sriov(struct ixgbe_adapter
>>> *adapter,
>>>    	IXGBE_WRITE_REG(hw, IXGBE_PFDTXGSWC, IXGBE_PFDTXGSWC_VT_LBEN);
>>>    	adapter->bridge_mode = BRIDGE_MODE_VEB;
>>>    -	/* limit trafffic classes based on VFs enabled */
>>> +	/* limit traffic classes based on VFs enabled */
>>>    	if ((adapter->hw.mac.type == ixgbe_mac_82599EB) && (num_vfs < 16)) {
>>>    		adapter->dcb_cfg.num_tcs.pg_tcs = MAX_TRAFFIC_CLASS;
>>>    		adapter->dcb_cfg.num_tcs.pfc_tcs = MAX_TRAFFIC_CLASS;
>>
>> Reviewed-by: Paul Menzel <pmenzel@...gen.mpg.de>
>>
>>
>> Kind regards,
>>
>> Paul
>>