linux-kernel - Re: [PATCH] tracing: disable kcov on trace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACT4Y+Zpasug=cr2k-17aD_EBsvMZB8kQnaJ+KPgoPOZAj___Q@mail.gmail.com>
Date:   Mon, 23 May 2022 10:35:57 +0200
From:   Dmitry Vyukov <dvyukov@...gle.com>
To:     Congyu Liu <liu3101@...due.edu>
Cc:     andreyknvl@...il.com, rostedt@...dmis.org, mingo@...hat.com,
        kasan-dev@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tracing: disable kcov on trace_preemptirq.c

On Mon, 23 May 2022 at 08:30, Congyu Liu <liu3101@...due.edu> wrote:
>
> Functions in trace_preemptirq.c could be invoked from early interrupt
> code that bypasses kcov trace function's in_task() check. Disable kcov
> on this file to reduce random code coverage.
>
> Signed-off-by: Congyu Liu <liu3101@...due.edu>

Acked-by: Dmitry Vyukov <dvyukov@...gle.com>

> ---
>  kernel/trace/Makefile | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/kernel/trace/Makefile b/kernel/trace/Makefile
> index d77cd8032213..0d261774d6f3 100644
> --- a/kernel/trace/Makefile
> +++ b/kernel/trace/Makefile
> @@ -31,6 +31,10 @@ ifdef CONFIG_GCOV_PROFILE_FTRACE
>  GCOV_PROFILE := y
>  endif
>
> +# Functions in this file could be invoked from early interrupt
> +# code and produce random code coverage.
> +KCOV_INSTRUMENT_trace_preemptirq.o := n
> +
>  CFLAGS_bpf_trace.o := -I$(src)
>
>  CFLAGS_trace_benchmark.o := -I$(src)
> --
> 2.34.1
>