lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 23 May 2022 08:45:06 +0000 From: "Starke, Daniel" <daniel.starke@...mens.com> To: Greg KH <gregkh@...uxfoundation.org> CC: "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>, "jirislaby@...nel.org" <jirislaby@...nel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: RE: [PATCH v2 1/9] tty: n_gsm: fix user open not possible at responder until initiator open > > +/** > > + * gsm_dlci_wait_open - wait for channel open procedure > > + * @dlci: DLCI to open > > + * > > + * Wait for a DLCI opening from the other side. Asynchronously wait until > > + * we get a SABM and set off timers and the responses. > > + */ > > +static void gsm_dlci_wait_open(struct gsm_dlci *dlci) { > > + switch (dlci->state) { > > + case DLCI_CLOSED: > > + case DLCI_CLOSING: > > + dlci->state = DLCI_OPENING; > > + break; > > + default: > > + break; > > + } > > +} > > The documentation for this function is odd, you are not waiting for > anything. You are just changing the state. This makes no sense as-is, > sorry. Thank you for your comment. I have prepared a new version. I will send it after the other 8 patches have been commented. Best regards, Daniel Starke
Powered by blists - more mailing lists