linux-kernel - Re: [PATCH] irq: mips: Export irq_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 23 May 2022 11:16:07 +0200
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     Genjian Zhang <zhanggenjian123@...il.com>
Cc:     maz@...nel.org, keescook@...omium.org, mark.rutland@....com,
        nathan@...nel.org, siyanteng01@...il.com, yyuasa@...ux.com,
        ralf@...ux-mips.org, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org, huhai@...inos.cn,
        k2ci <kernel-bot@...inos.cn>
Subject: Re: [PATCH] irq: mips: Export irq_err_count to modules

On Mon, May 23, 2022 at 04:16:25PM +0800, Genjian Zhang wrote:
> From: huhai <huhai@...inos.cn>
> 
> modpost complains once these drivers become modules.
>   ERROR: modpost: "irq_err_count" [drivers/gpio/gpio-vr41xx.ko] undefined!
> 
> Fix it by export them when that symbol is =m.
> 
> Fixes: 27fdd325dace ("MIPS: Update VR41xx GPIO driver to use gpiolib")
> Reported-by: k2ci <kernel-bot@...inos.cn>
> Signed-off-by: huhai <huhai@...inos.cn>
> ---
>  arch/mips/kernel/irq.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/arch/mips/kernel/irq.c b/arch/mips/kernel/irq.c
> index 5e11582fe308..b0038b715008 100644
> --- a/arch/mips/kernel/irq.c
> +++ b/arch/mips/kernel/irq.c
> @@ -38,6 +38,9 @@ void ack_bad_irq(unsigned int irq)
>  }
>  
>  atomic_t irq_err_count;
> +#ifdef CONFIG_GPIO_VR41XX_MODULE
> +EXPORT_SYMBOL_GPL(irq_err_count);
> +#endif

please use spurious_interrupt() in drivers/gpio/gpio-vr41xx.c.

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]