linux-kernel - Re: [PATCH v4] fs/proc/base.c: fix incorrect fmode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220523094058.nuj3xsgixzu2amac@wittgenstein>
Date:   Mon, 23 May 2022 11:40:58 +0200
From:   Christian Brauner <brauner@...nel.org>
To:     Vasily Averin <vvs@...nvz.org>
Cc:     Matthew Wilcox <willy@...radead.org>, kernel@...nvz.org,
        linux-kernel@...r.kernel.org,
        Christoph Hellwig <hch@...radead.org>, Jan Kara <jack@...e.cz>,
        linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH v4] fs/proc/base.c: fix incorrect fmode_t casts

On Mon, May 23, 2022 at 06:37:29AM +0300, Vasily Averin wrote:
> Fixes sparce warnings:
> fs/proc/base.c:2240:25: sparse: warning: cast to restricted fmode_t
> fs/proc/base.c:2297:42: sparse: warning: cast from restricted fmode_t
> fs/proc/base.c:2394:48: sparse: warning: cast from restricted fmode_t
> 
> fmode_t is birwie type and requires __force attribute for any cast
> 
> Signed-off-by: Vasily Averin <vvs@...nvz.org>
> Reviewed-by: Christoph Hellwig <hch@....de>
> ---

Looks good to me,
Reviewed-by: Christian Brauner (Microsoft) <brauner@...nel.org>