linux-kernel - Re: [PATCH v2] staging: greybus: Fix indentation in fw-management.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 23 May 2022 15:31:52 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Uri Arev <me@...tyapps.xyz>
Cc:     Viresh Kumar <vireshk@...nel.org>, Johan Hovold <johan@...nel.org>,
        Alex Elder <elder@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        greybus-dev@...ts.linaro.org, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: greybus: Fix indentation in fw-management.c

On Mon, May 23, 2022 at 03:08:57PM +0300, Uri Arev wrote:
> Reported by Checkpatch:
> CHECK: Alignment should match open parenthesis
> 
> -Uri
> 

Don't put your name in the commit message like this.

> Signed-off-by: Uri Arev <me@...tyapps.xyz>
> ---
> v2: More understandable title, add Signed-off-by line

Why didn't you fix this one as well?

CHECK: Alignment should match open parenthesis
#452: FILE: drivers/staging/greybus/fw-management.c:452:
+               ret = fw_mgmt_load_and_validate_operation(fw_mgmt,
+                               intf_load.load_method, intf_load.firmware_tag);

regards,
dan carpenter