linux-kernel - Re: [PATCH 2/3] clocksource/drivers/timer-ti-dm: Make timer selectable for ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5b71f5e8-c3df-46ef-094f-9739dd7a0f5f@linaro.org>
Date:   Mon, 23 May 2022 14:41:06 +0200
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Tony Lindgren <tony@...mide.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org,
        linux-omap@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        Keerthy <j-keerthy@...com>, Nishanth Menon <nm@...com>,
        Vignesh Raghavendra <vigneshr@...com>
Subject: Re: [PATCH 2/3] clocksource/drivers/timer-ti-dm: Make timer
 selectable for ARCH_K3


Hi Tony,

On 23/05/2022 09:13, Tony Lindgren wrote:
> Hi,
> 
> * Daniel Lezcano <daniel.lezcano@...aro.org> [220520 15:24]:
>> On 08/04/2022 12:17, Tony Lindgren wrote:
>>> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
>>> --- a/drivers/clocksource/Kconfig
>>> +++ b/drivers/clocksource/Kconfig
>>> @@ -22,7 +22,7 @@ config CLKEVT_I8253
>>>    config I8253_LOCK
>>>    	bool
>>> -config OMAP_DM_TIMER
>>> +config OMAP_DM_SYSTIMER
>>>    	bool
>>>    	select TIMER_OF
>>> @@ -56,6 +56,12 @@ config DIGICOLOR_TIMER
>>>    	help
>>>    	  Enables the support for the digicolor timer driver.
>>> +config OMAP_DM_TIMER
>>> +	tristate "OMAP dual-mode timer driver" if ARCH_K3 || COMPILE_TEST
>>
>> Actually, I missed this. Could you convert to a 'bool' there is no module in
>> the timer drivers ATM.
> 
> OK sure will do.
> 
> Did you notice some loadable module usage issues for timers that are not
> system timers? Just wondering if there are some issues that I did not
> notice.

I think the removal won't be supported. We already had a proposal to 
move one of the timer as a module but I wanted to have more insights 
about the changes, not just do that because of a GKI Android.



-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog