linux-kernel - Re: [PATCH v2 -next] drm/display: Fix build error without CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 23 May 2022 14:54:59 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     airlied@...ux.ie, daniel@...ll.ch, tzimmermann@...e.de,
        dmitry.baryshkov@...aro.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v2 -next] drm/display: Fix build error without CONFIG_OF

On Mon, May 23, 2022 at 2:46 PM Linus Walleij <linus.walleij@...aro.org> wrote:
> On Fri, May 6, 2022 at 2:33 PM YueHaibing <yuehaibing@...wei.com> wrote:
>
> > While CONFIG_OF is n but COMPILE_TEST is y, we got this:
> >
> > WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS
> >   Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && OF [=n]
> >   Selected by [y]:
> >   - DRM_MSM [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_QCOM || SOC_IMX5 || COMPILE_TEST [=y]) && COMMON_CLK [=y] && IOMMU_SUPPORT [=y] && (QCOM_OCMEM [=n] || QCOM_OCMEM [=n]=n) && (QCOM_LLCC [=y] || QCOM_LLCC [=y]=n) && (QCOM_COMMAND_DB [=n] || QCOM_COMMAND_DB [=n]=n)
> >
> > Make DRM_DP_AUX_BUS depends on OF || COMPILE_TEST to fix this warning.
> >
> > Fixes: f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support")
> > Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>
> Patch applied to the DRM tree.

Nope, failed:

$ dim push-branch drm-misc-next
dim: ac890b9eeb9b ("drm/display: Fix build error without CONFIG_OF"):
Fixes: SHA1 in not pointing at an ancestor:
dim:     f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus support")
dim: ERROR: issues in commits detected, aborting

I don't know what to do with this, sorry. The other committers are maybe better
with this kind of situations. I think it is designed to stop me from
shooting myself
in the foot.

Yours,
Linus Walleij