linux-kernel - Re: [PATCH v2 0/8] Make more tests skip rather than fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YouGoc9elnPwV5IM@kernel.org>
Date:   Mon, 23 May 2022 10:05:37 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Ian Rogers <irogers@...gle.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Riccardo Mancini <rickyman7@...il.com>,
        Sohaib Mohamed <sohaib.amhmd@...il.com>,
        Carsten Haitzler <carsten.haitzler@....com>,
        Marco Elver <elver@...gle.com>,
        John Garry <john.garry@...wei.com>,
        Michael Petlan <mpetlan@...hat.com>,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org,
        Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH v2 0/8] Make more tests skip rather than fail

Em Tue, May 17, 2022 at 09:20:19PM -0700, Ian Rogers escreveu:
> A long standing niggle has been that tests that cannot pass are marked
> as failing rather than skip.  John Garry mentioned a similar concern
> in [1]. These changes fix this behavior so that as root, or not, at
> least the first 10 tests are passing or skipping.
> 
> [1] https://lore.kernel.org/lkml/d32376b5-5538-ff00-6620-e74ad4b4abf2@huawei.com/
> 
> v2. Updates reviewed-by and acked-by. It addresses review comments
>     from Namhyung Kim <namhyung@...nel.org>. An extra fix is now
>     included for PERF_RECORD_* which can fail as a user because of
>     perf_event_paranoid.

Thanks, applied.

- Arnaldo

 
> Ian Rogers (8):
>   perf test: Skip reason for suites with 1 test
>   perf test: Use skip in vmlinux kallsyms
>   perf test: Use skip in openat syscall
>   perf test: Basic mmap use skip
>   perf test: Parse events tidy terms_test
>   perf test: Parse events tidy evlist_test
>   perf test: Parse events break apart tests
>   perf test: Use skip in PERF_RECORD_*
> 
>  tools/perf/tests/builtin-test.c            |   6 +-
>  tools/perf/tests/mmap-basic.c              |  18 +-
>  tools/perf/tests/openat-syscall-all-cpus.c |  23 +-
>  tools/perf/tests/openat-syscall.c          |  20 +-
>  tools/perf/tests/parse-events.c            | 492 +++++++++++----------
>  tools/perf/tests/perf-record.c             |  18 +-
>  tools/perf/tests/vmlinux-kallsyms.c        |  12 +-
>  7 files changed, 341 insertions(+), 248 deletions(-)
> 
> -- 
> 2.36.0.550.gb090851708-goog

-- 

- Arnaldo