linux-kernel - Re: [PATCH] MIPS: CPC: Fix refcount leak in mips_cpc_default_phys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220523131601.uo2ts4vjj6qvibxy@mobilestation>
Date:   Mon, 23 May 2022 16:16:01 +0300
From:   Serge Semin <fancer.lancer@...il.com>
To:     Miaoqian Lin <linmq006@...il.com>
Cc:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Miodrag Dinic <miodrag.dinic@...s.com>,
        James Hogan <jhogan@...nel.org>,
        Paul Burton <paulburton@...nel.org>,
        Aleksandar Markovic <aleksandar.markovic@...s.com>,
        linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: CPC: Fix refcount leak in
 mips_cpc_default_phys_base


On Mon, May 16, 2022 at 08:33:50AM +0400, Miaoqian Lin wrote:
> of_find_compatible_node() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when done.
> Add missing of_node_put() to avoid refcount leak.
> 
> Fixes: 791412dafbbf ("MIPS: CPC: Map registers using DT in mips_cpc_default_phys_base()")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>

Right. It's similar to the CDMM fix:
commit 4528668ca331 ("mips: cdmm: Fix refcount leak in mips_cdmm_phys_base")

Reviewed-by: Serge Semin <fancer.lancer@...il.com>

-Sergey

> ---
>  arch/mips/kernel/mips-cpc.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/mips/kernel/mips-cpc.c b/arch/mips/kernel/mips-cpc.c
> index 17aff13cd7ce..3e386f7e1545 100644
> --- a/arch/mips/kernel/mips-cpc.c
> +++ b/arch/mips/kernel/mips-cpc.c
> @@ -28,6 +28,7 @@ phys_addr_t __weak mips_cpc_default_phys_base(void)
>  	cpc_node = of_find_compatible_node(of_root, NULL, "mti,mips-cpc");
>  	if (cpc_node) {
>  		err = of_address_to_resource(cpc_node, 0, &res);
> +		of_node_put(cpc_node);
>  		if (!err)
>  			return res.start;
>  	}
> -- 
> 2.25.1
>