lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 23 May 2022 16:11:00 +0200 From: Javier Martinez Canillas <javierm@...hat.com> To: Geert Uytterhoeven <geert@...ux-m68k.org> Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Daniel Vetter <daniel@...ll.ch>, David Airlie <airlied@...ux.ie>, David Lechner <david@...hnology.com>, Sam Ravnborg <sam@...nborg.org>, DRI Development <dri-devel@...ts.freedesktop.org>, Mark Brown <broonie@...nel.org>, linux-spi <linux-spi@...r.kernel.org> Subject: Re: [PATCH] drm/st7735r: Fix module autoloading for Okaya RH128128T Hello Geert, On 5/20/22 14:02, Geert Uytterhoeven wrote: > Hi Javier, > > CC spi > > On Fri, May 20, 2022 at 11:16 AM Javier Martinez Canillas > <javierm@...hat.com> wrote: >> The SPI core always reports a "MODALIAS=spi:<foo>", even if the device was >> registered via OF. This means that the st7735r.ko module won't autoload if >> a DT has a node with a compatible "okaya,rh128128t" string. >> >> In that case, kmod expects a "MODALIAS=of:N*T*Cokaya,rh128128t" uevent but >> instead will get a "MODALIAS=spi:rh128128t", which is not present in the >> list of aliases: >> >> $ modinfo drivers/gpu/drm/tiny/st7735r.ko | grep alias >> alias: of:N*T*Cokaya,rh128128tC* >> alias: of:N*T*Cokaya,rh128128t >> alias: of:N*T*Cjianda,jd-t18003-t01C* >> alias: of:N*T*Cjianda,jd-t18003-t01 >> alias: spi:jd-t18003-t01 >> >> To workaround this issue, add in the SPI table an entry for that device. >> >> Fixes: d1d511d516f7 ("drm: tiny: st7735r: Add support for Okaya RH128128T") >> Signed-off-by: Javier Martinez Canillas <javierm@...hat.com> > > Thanks for your patch! > We really need to fix this at the subsystem level. > Yes, agreed. > Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be> > Thanks! I've pushed this to drm-misc (drm-misc-next) with your Reviewed-by and David's Acked-by. -- Best regards, Javier Martinez Canillas Linux Engineering Red Hat
Powered by blists - more mailing lists