linux-kernel - [PATCH] ARM: tegra: Fix refcount leak in tegra114_gic_cpu_pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 23 May 2022 19:20:36 +0400
From:   Miaoqian Lin <linmq006@...il.com>
To:     Russell King <linux@...linux.org.uk>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Miaoqian Lin <linmq006@...il.com>,
        Joseph Lo <josephl@...dia.com>,
        Stephen Warren <swarren@...dia.com>,
        linux-arm-kernel@...ts.infradead.org, linux-tegra@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] ARM: tegra: Fix refcount leak in tegra114_gic_cpu_pm_registration

of_find_matching_node() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: 7e8b15dbc392 ("ARM: tegra114: Reprogram GIC CPU interface to bypass IRQ on CPU PM entry")
Signed-off-by: Miaoqian Lin <linmq006@...il.com>
---
 arch/arm/mach-tegra/irq.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-tegra/irq.c b/arch/arm/mach-tegra/irq.c
index 4e1ee70b2a3f..d51bdd46219e 100644
--- a/arch/arm/mach-tegra/irq.c
+++ b/arch/arm/mach-tegra/irq.c
@@ -73,7 +73,7 @@ static void __init tegra114_gic_cpu_pm_registration(void)
 		return;
 
 	tegra_gic_cpu_base = of_iomap(dn, 1);
-
+	of_node_put(dn);
 	cpu_pm_register_notifier(&tegra_gic_notifier_block);
 }
 #else
-- 
2.25.1