linux-kernel - Re: [PATCH] dt-bindings: Renamed hte directory to timestamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 23 May 2022 11:05:21 -0500
From:   Rob Herring <robh+dt@...nel.org>
To:     Dipen Patel <dipenp@...dia.com>
Cc:     linux-tegra <linux-tegra@...r.kernel.org>,
        devicetree@...r.kernel.org,
        Linus Walleij <linus.walleij@...aro.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Thierry Reding <thierry.reding@...il.com>
Subject: Re: [PATCH] dt-bindings: Renamed hte directory to timestamp

On Tue, May 17, 2022 at 7:35 PM Rob Herring <robh@...nel.org> wrote:
>
> On Thu, 12 May 2022 10:50:11 -0700, Dipen Patel wrote:
> > Renamed hte dt binding directory to timestamp according review comment.
> > Addressed minor comment about having HTE acronym first in the common dt
> > binding document.
> >
> > The change reflects above renaming in MAINTAINERS files too.
> >
> > Signed-off-by: Dipen Patel <dipenp@...dia.com>
> > ---
> > This patch is on top of old series (Intro to Hardware timestamping
> > engine V6) present in linux-next tentatively in preparation for
> > merge.
> >
> >  .../{hte => timestamp}/hardware-timestamps-common.yaml      | 6 +++---
> >  .../bindings/{hte => timestamp}/hte-consumer.yaml           | 0
> >  .../bindings/{hte => timestamp}/nvidia,tegra194-hte.yaml    | 0
> >  MAINTAINERS                                                 | 2 +-
> >  4 files changed, 4 insertions(+), 4 deletions(-)
> >  rename Documentation/devicetree/bindings/{hte => timestamp}/hardware-timestamps-common.yaml (71%)
> >  rename Documentation/devicetree/bindings/{hte => timestamp}/hte-consumer.yaml (100%)
> >  rename Documentation/devicetree/bindings/{hte => timestamp}/nvidia,tegra194-hte.yaml (100%)
> >
>
> Acked-by: Rob Herring <robh@...nel.org>

I take that back:

./Documentation/devicetree/bindings/timestamp/hte-consumer.yaml: $id:
relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/timestamp/hte-consumer.yaml#
./Documentation/devicetree/bindings/timestamp/nvidia,tegra194-hte.yaml:
$id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/timestamp/nvidia,tegra194-hte.yaml#
./Documentation/devicetree/bindings/timestamp/hardware-timestamps-common.yaml:
$id: relative path/filename doesn't match actual path or filename
expected: http://devicetree.org/schemas/timestamp/hardware-timestamps-common.yaml#


I was wondering why a new common binding was already in next without a
Reviewed-by, but I let that slide. Now I regret doing that.

Rob