linux-kernel - Re: [PATCH v2 1/2] dt-bindings: leds: lp50xx: correct reg/unit addresses in example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220524183430.GA4134907-robh@kernel.org>
Date:   Tue, 24 May 2022 13:34:30 -0500
From:   Rob Herring <robh@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Pavel Machek <pavel@....cz>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Dan Murphy <dmurphy@...com>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Sven Schwermer <sven.schwermer@...ruptive-technologies.com>,
        linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Kyle Swenson <kyle.swenson@....tech>
Subject: Re: [PATCH v2 1/2] dt-bindings: leds: lp50xx: correct reg/unit
 addresses in example

On Tue, May 24, 2022 at 09:08:14AM +0200, Krzysztof Kozlowski wrote:
> The multi-led node defined address/size cells, so it intended to have
> children with unit addresses.
> 
> The second multi-led's reg property defined three LED indexes within one
> reg item, which is not correct - these are three separate items.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> ---
> 
> Changes since v1:
> 1. Correct multi-led unit address as well (Rob).
> 
> Cc: Kyle Swenson <kyle.swenson@....tech>
> ---
>  .../devicetree/bindings/leds/leds-lp50xx.yaml | 24 ++++++++++++-------
>  1 file changed, 15 insertions(+), 9 deletions(-)

Reviewed-by: Rob Herring <robh@...nel.org>