linux-kernel - Re: [PATCH] drm/amdgpu/discovery: make amdgpu_discovery_get_mall

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <be333969-560d-36da-79cc-9d223ad675a2@amd.com>
Date:   Tue, 24 May 2022 17:22:29 -0400
From:   Luben Tuikov <luben.tuikov@....com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        alexander.deucher@....com
Cc:     christian.koenig@....com, Xinhui.Pan@....com, airlied@...ux.ie,
        daniel@...ll.ch, Likun.Gao@....com, flora.cui@....com,
        yifan1.zhang@....com, amd-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] drm/amdgpu/discovery: make amdgpu_discovery_get_mall_info
 static

This is already static, in our local branch, from this commit:

commit 6852e61a0917a2
Author: Evan Quan <evan.quan@....com>
Date:   Thu May 19 17:28:12 2022 +0800

    drm/amdgpu: suppress some compile warnings
    
    Suppress two compile warnings about "no previous prototype".
    
    Reported-by: kernel test robot <lkp@...el.com>
    Signed-off-by: Evan Quan <evan.quan@....com>
    Reviewed-by: Alex Deucher <alexander.deucher@....com>

Regards,
Luben


On 2022-05-24 04:11, Jiapeng Chong wrote:
> This symbol is not used outside of amdgpu_discovery.c, so marks it static.
> 
> Fixes the following w1 warning:
> 
> drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1364:5: warning: no
> previous prototype for ‘amdgpu_discovery_get_mall_info’
> [-Wmissing-prototypes].
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> index 881570dced41..16cdfb30b013 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c
> @@ -1361,7 +1361,7 @@ union mall_info {
>  	struct mall_info_v1_0 v1;
>  };
>  
> -int amdgpu_discovery_get_mall_info(struct amdgpu_device *adev)
> +static int amdgpu_discovery_get_mall_info(struct amdgpu_device *adev)
>  {
>  	struct binary_header *bhdr;
>  	union mall_info *mall_info;

Regards,
-- 
Luben