linux-kernel - Re: [PATCH] mtd: spi-nor: atmel: Add at25ql641 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0123ee0e70df13b340230a38cb44548f@walle.cc>
Date:   Wed, 25 May 2022 00:37:16 +0200
From:   Michael Walle <michael@...le.cc>
To:     chf.fritz@...glemail.com
Cc:     Tudor Ambarus <tudor.ambarus@...rochip.com>,
        Pratyush Yadav <p.yadav@...com>,
        Miquel Raynal <miquel.raynal@...tlin.com>,
        Richard Weinberger <richard@....at>,
        Vignesh Raghavendra <vigneshr@...com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        ClaudiuBeznea <claudiu.beznea@...rochip.com>,
        linux-mtd@...ts.infradead.org,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mtd: spi-nor: atmel: Add at25ql641 support

Hi,

Am 2022-05-24 21:20, schrieb Christoph Fritz:
> This patch adds AT25QL641 to the list of supported nor flashs.

Please mention on which spi host controller this flash was
tested.

> Signed-off-by: Christoph Fritz <chf.fritz@...glemail.com>
> ---
>  drivers/mtd/spi-nor/atmel.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mtd/spi-nor/atmel.c b/drivers/mtd/spi-nor/atmel.c
> index 656dd80a0be7..dfbc12071093 100644
> --- a/drivers/mtd/spi-nor/atmel.c
> +++ b/drivers/mtd/spi-nor/atmel.c
> @@ -186,6 +186,8 @@ static const struct flash_info atmel_nor_parts[] = 
> {
>  		.fixups = &atmel_nor_global_protection_fixups },
>  	{ "at25sl321",	INFO(0x1f4216, 0, 64 * 1024, 64)
>  		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> +	{ "at25ql641",	INFO(0x1f4317, 0, 64 * 1024, 128)
> +		NO_SFDP_FLAGS(SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },

This flash supports SFDP, please use either SNOR_ID3() (you'll
have to pick my pending patches first [1]) or use
   { "at25ql641", INFO(0x1f4317, 0, 0, 0) PARSE_SFDP },
which will then be replaced with SNOR_ID3() once it is available.

>  	{ "at26f004",   INFO(0x1f0400, 0, 64 * 1024,  8)
>  		NO_SFDP_FLAGS(SECT_4K) },
>  	{ "at26df081a", INFO(0x1f4501, 0, 64 * 1024, 16)

-michael

[1] https://lore.kernel.org/r/966de7ad5f563f9a29db91c5309a71c6@walle.cc/