linux-kernel - Re: [PATCH] LoongArch: Fix unsigned function returning negative constant

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAhV-H4o62v7h5o7jTsORZPyqNaxyNYF-EOZgzmJQwDjsyWn1w@mail.gmail.com>
Date:   Tue, 24 May 2022 12:02:41 +0800
From:   Huacai Chen <chenhuacai@...nel.org>
To:     Haowen Bai <baihaowen@...zu.com>
Cc:     Ard Biesheuvel <ardb@...nel.org>,
        linux-efi <linux-efi@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] LoongArch: Fix unsigned function returning negative constant

On Tue, May 24, 2022 at 11:04 AM Huacai Chen <chenhuacai@...nel.org> wrote:
>
> Hi, Haowen,
>
> On Tue, May 24, 2022 at 10:47 AM Haowen Bai <baihaowen@...zu.com> wrote:
> >
> > The function set_virtual_map has an unsigned return type, but returns a
> > negative constant to indicate an error condition. So we change unsigned
> > to int.
> Your patch is correct, but original hasn't been upstream, I don't
> know how to handle it.
I've squash your patch to the original one and add a Co-developed-by:,
not sure it is the best solution. Thanks.

>
> Huacai
> >
> > Signed-off-by: Haowen Bai <baihaowen@...zu.com>
> > ---
> >  arch/loongarch/kernel/efi.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/loongarch/kernel/efi.c b/arch/loongarch/kernel/efi.c
> > index 69ebdd4220ec..f9fdeb1ae358 100644
> > --- a/arch/loongarch/kernel/efi.c
> > +++ b/arch/loongarch/kernel/efi.c
> > @@ -102,7 +102,7 @@ static void __init fix_efi_mapping(void)
> >   * in @memory_map whose EFI_MEMORY_RUNTIME attribute is set. Those descriptors
> >   * are also copied to @runtime_map, and their total count is returned in @count.
> >   */
> > -static unsigned int __init set_virtual_map(void)
> > +static int __init set_virtual_map(void)
> >  {
> >         int count = 0;
> >         unsigned int size;
> > --
> > 2.7.4
> >