linux-kernel - Re: [PATCH] powerpc: check previous kernel's ima-kexec-buffer against memory bounds

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87tu9ffp6j.fsf@vajain21.in.ibm.com>
Date:   Tue, 24 May 2022 11:27:24 +0530
From:   Vaibhav Jain <vaibhav@...ux.ibm.com>
To:     Michael Ellerman <mpe@...erman.id.au>,
        Rob Herring <robh@...nel.org>
Cc:     devicetree@...r.kernel.org, Frank Rowand <frowand.list@...il.com>,
        linux-kernel@...r.kernel.org,
        Prakhar Srivastava <prsriva@...ux.microsoft.com>,
        Lakshmi Ramasubramanian <nramas@...ux.microsoft.com>,
        linuxppc-dev@...ts.ozlabs.org,
        Thiago Jung Bauermann <bauerman@...ux.ibm.com>
Subject: Re: [PATCH] powerpc: check previous kernel's ima-kexec-buffer
 against memory bounds


Michael Ellerman <mpe@...erman.id.au> writes:

<snip>
>
> Rob's point is that commit fee3ff99bc67 only moved existing code, the
> bug already existed.
>
> The function was introduced in:
>
>   467d27824920 ("powerpc: ima: get the kexec buffer passed by the previous kernel")
>
> So that's where the Fixes tag should point.

Thanks Mpe for explaining and apologies Rob as I initially didnt get the
point you made. I wrongly assumed that since the patch can only be
applied on top of commit fee3ff99bc67 hence fixes should point to
fee3ff99bc67.

I have sent out a v2 with the updated Fixes tag and also changes as
suggested by Mpe and Rob at
https://lore.kernel.org/all/20220524055042.1527968-1-vaibhav@linux.ibm.com/

-- 
Cheers
~ Vaibhav