linux-kernel - Re: [PATCH 1/2] dt-bindings: leds: lp50xx: correct reg/unit addresses in example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 24 May 2022 08:36:10 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Rob Herring <robh@...nel.org>
Cc:     Pavel Machek <pavel@....cz>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Dan Murphy <dmurphy@...com>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Sven Schwermer <sven.schwermer@...ruptive-technologies.com>,
        linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, Kyle Swenson <kyle.swenson@....tech>
Subject: Re: [PATCH 1/2] dt-bindings: leds: lp50xx: correct reg/unit addresses
 in example

On 23/05/2022 23:35, Rob Herring wrote:
> On Wed, May 18, 2022 at 10:22:14AM +0200, Krzysztof Kozlowski wrote:
>> The multi-led node defined address/size cells, so it intended to have
>> children with unit addresses.
>>
>> The second multi-led's reg property defined three LED indexes within one
>> reg item, which is not correct - these are three separate items.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>>
>> ---
>>
>> Cc: Kyle Swenson <kyle.swenson@....tech>
>> ---
>>  .../devicetree/bindings/leds/leds-lp50xx.yaml | 22 ++++++++++++-------
>>  1 file changed, 14 insertions(+), 8 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
>> index f12fe5b53f30..dc1ac905bb91 100644
>> --- a/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
>> +++ b/Documentation/devicetree/bindings/leds/leds-lp50xx.yaml
>> @@ -99,35 +99,41 @@ examples:
>>                 color = <LED_COLOR_ID_RGB>;
>>                 function = LED_FUNCTION_CHARGING;
>>  
>> -               led-0 {
>> +               led@0 {
>> +                   reg = <0x0>;
>>                     color = <LED_COLOR_ID_RED>;
>>                 };
>>  
>> -               led-1 {
>> +               led@1 {
>> +                   reg = <0x1>;
>>                     color = <LED_COLOR_ID_GREEN>;
>>                 };
>>  
>> -               led-2 {
>> +               led@2 {
>> +                   reg = <0x2>;
>>                     color = <LED_COLOR_ID_BLUE>;
>>                 };
>>            };
>>  
>>            multi-led@2 {
>>              #address-cells = <1>;
>> -            #size-cells = <2>;
>> -            reg = <0x2 0x3 0x5>;
>> +            #size-cells = <0>;
>> +            reg = <0x3>, <0x4>, <0x5>;
> 
> The unit-address is 2, but the reg value is 3?

Right, the multi-led should be also @3 to match the reg and first led in
children.

Thanks.


Best regards,
Krzysztof