linux-kernel - Re: [PATCH] rtc: rzn1: Fix inconsistent IS_ERR and PTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220524091930.51e2a7ef@xps-13>
Date:   Tue, 24 May 2022 09:19:30 +0200
From:   Miquel Raynal <miquel.raynal@...tlin.com>
To:     Haowen Bai <baihaowen@...zu.com>
Cc:     Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Michel Pollet <michel.pollet@...renesas.com>,
        <linux-rtc@...r.kernel.org>, <linux-renesas-soc@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rtc: rzn1: Fix  inconsistent IS_ERR and PTR_ERR

Hi Haowen,

baihaowen@...zu.com wrote on Tue, 24 May 2022 14:09:45 +0800:

> The proper pointer to be passed as argument is rtc->rtcdev.
> Detected using Coccinelle.
> 
> Fixes: deeb4b5393e1 ("rtc: rzn1: Add new RTC driver")

Thanks for your patch. This has already been reported twice,
Alexandre will likely apply one of the fixes after the merge window.

> 
> Signed-off-by: Haowen Bai <baihaowen@...zu.com>
> ---
>  drivers/rtc/rtc-rzn1.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c
> index f92d1398b0f1..4cf54af8a8c3 100644
> --- a/drivers/rtc/rtc-rzn1.c
> +++ b/drivers/rtc/rtc-rzn1.c
> @@ -348,7 +348,7 @@ static int rzn1_rtc_probe(struct platform_device *pdev)
>  
>  	rtc->rtcdev = devm_rtc_allocate_device(&pdev->dev);
>  	if (IS_ERR(rtc->rtcdev))
> -		return PTR_ERR(rtc);
> +		return PTR_ERR(rtc->rtcdev);
>  
>  	rtc->rtcdev->range_min = RTC_TIMESTAMP_BEGIN_2000;
>  	rtc->rtcdev->range_max = RTC_TIMESTAMP_END_2099;


Thanks,
Miquèl