linux-kernel - [PATCH] watchdog: change "char *" string form to "char []"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220524003335.64801-1-yuzhe@nfschina.com>
Date:   Mon, 23 May 2022 17:33:35 -0700
From:   Yu Zhe <yuzhe@...china.com>
To:     sander@...nheule.net, wim@...ux-watchdog.org, linux@...ck-us.net
Cc:     linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org,
        Yu Zhe <yuzhe@...china.com>
Subject: [PATCH] watchdog: change "char *" string form to "char []"

The string form of "char []" declares a single variable. It is better
than "char *" which creates two variables.

Signed-off-by: Yu Zhe <yuzhe@...china.com>
---
 drivers/watchdog/realtek_otto_wdt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/realtek_otto_wdt.c b/drivers/watchdog/realtek_otto_wdt.c
index 60058a0c3ec4..c653ec73a999 100644
--- a/drivers/watchdog/realtek_otto_wdt.c
+++ b/drivers/watchdog/realtek_otto_wdt.c
@@ -265,7 +265,7 @@ static int otto_wdt_probe_clk(struct otto_wdt_ctrl *ctrl)
 
 static int otto_wdt_probe_reset_mode(struct otto_wdt_ctrl *ctrl)
 {
-	static const char *mode_property = "realtek,reset-mode";
+	static const char mode_property[] = "realtek,reset-mode";
 	const struct fwnode_handle *node = ctrl->dev->fwnode;
 	int mode_count;
 	u32 mode;
-- 
2.25.1