linux-kernel - Re: [PATCH V3] octeon_ep: Remove unnecessary cast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <195ae1109ca06c690f3fba7475e789180a328654.camel@redhat.com>
Date:   Tue, 24 May 2022 12:27:51 +0200
From:   Paolo Abeni <pabeni@...hat.com>
To:     Haowen Bai <baihaowen@...zu.com>,
        Veerasenareddy Burru <vburru@...vell.com>,
        Abhijit Ayarekar <aayarekar@...vell.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3] octeon_ep: Remove unnecessary cast

Hello,

On Tue, 2022-05-24 at 14:41 +0800, Haowen Bai wrote:
> ./drivers/net/ethernet/marvell/octeon_ep/octep_rx.c:161:18-40: WARNING:
> casting value returned by memory allocation function to (struct
> octep_rx_buffer *) is useless.
> 
> and we do more optimization:
> 1. remove casting value
> 2. use obvious size
> 3. use kvcalloc instead of vzalloc
> 
> Signed-off-by: Haowen Bai <baihaowen@...zu.com>

This looks like net-next material and net-next is closed for the next 2
weeks:

http://vger.kernel.org/~davem/net-next.html

Please repost when it re-opens.

Thanks,

Paolo