linux-kernel - Re: [PATCH] LoongArch: take size of pointed value, not pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 24 May 2022 14:11:33 +0200
From:   Ard Biesheuvel <ardb@...nel.org>
To:     Huacai Chen <chenhuacai@...nel.org>
Cc:     Haowen Bai <baihaowen@...zu.com>,
        linux-efi <linux-efi@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] LoongArch: take size of pointed value, not pointer

On Tue, 24 May 2022 at 13:41, Huacai Chen <chenhuacai@...nel.org> wrote:
>
> Hi, Haowen,
>
> On Tue, May 24, 2022 at 12:03 PM Huacai Chen <chenhuacai@...nel.org> wrote:
> >
> > On Tue, May 24, 2022 at 11:06 AM Huacai Chen <chenhuacai@...nel.org> wrote:
> > >
> > > Hi, Haowen,
> > >
> > > On Tue, May 24, 2022 at 10:52 AM Haowen Bai <baihaowen@...zu.com> wrote:
> > > >
> > > > Sizeof a pointer-typed expression returns the size of the pointer, not
> > > > that of the pointed data.
> > > Your patch is correct, but the original patch hasn't been upstream, I don't
> > > know how to handle it.
> > I've squash your patch to the original one and add a Co-developed-by:,
> > not sure it is the best solution. Thanks.
> I was suggested that a "Suggested-by" is suitable.
> https://lore.kernel.org/lkml/CAAhV-H6k=xC-fDYnwsqSeoj7QPPn8RAcR+waQMa8yTs5J-XOSg@mail.gmail.com/T/#t
>

Finding and fixing mistakes is the normal review process, and not
every addressed comment needs to be reflected in the tags, even if the
contributor sent it as a separate patch. Adding 'Suggested-by' to the
entire patch falsely implies that the author of the bugfix suggested
the entire work, which is not desirable either.

In this case, the bugfix is a well-known anti-pattern which is not
specific to the introduced code. I don't think this warrants a tag
tbh.