lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 24 May 2022 15:03:07 +0200 From: Paolo Abeni <pabeni@...hat.com> To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>, davem@...emloft.net Cc: edumazet@...gle.com, kuba@...nel.org, linux-usb@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Abaci Robot <abaci@...ux.alibaba.com> Subject: Re: [PATCH] r8152: Return true/false (not 1/0) from bool functions On Tue, 2022-05-24 at 17:37 +0800, Jiapeng Chong wrote: > Return statements in functions returning bool should use true/false > instead of 1/0. > > Clean the following coccicheck warning: > > ./drivers/net/usb/r8152.c:9579:10-11: WARNING: return of 0/1 in function > 'rtl8152_supports_lenovo_macpassthru' with return type bool. > > Reported-by: Abaci Robot <abaci@...ux.alibaba.com> > Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com> > --- > drivers/net/usb/r8152.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c > index 7389d6ef8569..7b7704b4b500 100644 > --- a/drivers/net/usb/r8152.c > +++ b/drivers/net/usb/r8152.c > @@ -9576,15 +9576,15 @@ static bool rtl8152_supports_lenovo_macpassthru(struct usb_device *udev) > case DEVICE_ID_THINKPAD_USB_C_DOCK_GEN2: > case DEVICE_ID_THINKPAD_USB_C_DOCK_GEN3: > case DEVICE_ID_THINKPAD_USB_C_DONGLE: > - return 1; > + return true; > } > } else if (vendor_id == VENDOR_ID_REALTEK && parent_vendor_id == VENDOR_ID_LENOVO) { > switch (product_id) { > case 0x8153: > - return 1; > + return true; > } > } > - return 0; > + return false; > } > > static int rtl8152_probe(struct usb_interface *intf, This looks like net-next material, and net-next is currently closed, please resubmit in ~2weeks specifying the target tree in the subj. Thanks Paolo
Powered by blists - more mailing lists