linux-kernel - [PATCH 6/7] remoteproc: qcom: Check elf class before minidump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1653398017-28426-7-git-send-email-quic_sibis@quicinc.com>
Date:   Tue, 24 May 2022 18:43:36 +0530
From:   Sibi Sankar <quic_sibis@...cinc.com>
To:     <bjorn.andersson@...aro.org>
CC:     <agross@...nel.org>, <mathieu.poirier@...aro.org>,
        <dmitry.baryshkov@...aro.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-remoteproc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Siddharth Gupta <sidgup@...eaurora.org>,
        Sibi Sankar <quic_sibis@...cinc.com>
Subject: [PATCH 6/7] remoteproc: qcom: Check elf class before minidump

From: Siddharth Gupta <sidgup@...eaurora.org>

When the minidump is done with the elf64 class we need to create
the dumps using the section headers, otherwise we need to default
to dump creation using the program headers.

Fixes: 8ed8485c4f05 ("remoteproc: qcom: Add capability to collect minidumps")
Signed-off-by: Siddharth Gupta <sidgup@...eaurora.org>
Signed-off-by: Sibi Sankar <quic_sibis@...cinc.com>
---
 drivers/remoteproc/qcom_common.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/remoteproc/qcom_common.c b/drivers/remoteproc/qcom_common.c
index 4b91e3c9eafa..959fb24d57ec 100644
--- a/drivers/remoteproc/qcom_common.c
+++ b/drivers/remoteproc/qcom_common.c
@@ -174,7 +174,11 @@ void qcom_minidump(struct rproc *rproc, unsigned int minidump_id)
 		dev_err(&rproc->dev, "Failed with error: %d while adding minidump entries\n", ret);
 		goto clean_minidump;
 	}
-	rproc_coredump_using_sections(rproc);
+
+	if (rproc->elf_class == ELFCLASS64)
+		rproc_coredump_using_sections(rproc);
+	else
+		rproc_coredump(rproc);
 clean_minidump:
 	qcom_minidump_cleanup(rproc);
 }
-- 
2.7.4